From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, cjashfor@linux.vnet.ibm.com,
mingo@elte.hu, fweisbec@gmail.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf-events: Add support for supplementary event registers v2
Date: Mon, 15 Nov 2010 12:06:08 +0100 [thread overview]
Message-ID: <20101115110608.GE7269@basil.fritz.box> (raw)
In-Reply-To: <AANLkTikr-rOYALdUiRDFahqE1GECO5XNKnbN9LNZBebU@mail.gmail.com>
On Mon, Nov 15, 2010 at 12:03:28PM +0100, Stephane Eranian wrote:
> On Sat, Nov 13, 2010 at 11:34 AM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > On Sat, 2010-11-13 at 11:17 +0100, Andi Kleen wrote:
> >> > That would assume a single event doesn't contain offcore and lbr, no?
> >> > Currently the extra_reg thing assumes there's only one extra reg encoded
> >> > in the config word.
> >>
> >> It would not be too hard to make it an array if that's needed.
> >
> > I don't think we want to go there anyway, one extra_reg per config value
> > is fine.
> >
> I think offcore goes into .config, lbr goes into extra_reg. That should take
> care of combinations as well.
The context switch code needs extra_reg for any extra regs including
offcore, I don't want to walk the event table for that.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-11-15 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 16:55 [PATCH 1/2] perf-events: Add support for supplementary event registers v2 Andi Kleen
2010-11-12 16:55 ` [PATCH 2/2] perf-events: Fix LLC-* events on Intel Nehalem/Westmere v2 Andi Kleen
2010-11-12 17:17 ` [PATCH 1/2] perf-events: Add support for supplementary event registers v2 Peter Zijlstra
2010-11-12 17:17 ` Stephane Eranian
2010-11-12 17:33 ` Peter Zijlstra
2010-11-12 21:26 ` Stephane Eranian
2010-11-13 10:17 ` Andi Kleen
2010-11-13 10:34 ` Peter Zijlstra
2010-11-15 11:03 ` Stephane Eranian
2010-11-15 11:06 ` Andi Kleen [this message]
2010-11-15 11:00 ` Stephane Eranian
2010-11-12 17:23 ` Peter Zijlstra
2010-11-13 10:13 ` Andi Kleen
2010-11-13 10:32 ` Peter Zijlstra
2010-11-15 11:01 ` Stephane Eranian
2010-11-15 11:06 ` Peter Zijlstra
2010-11-15 11:17 ` Andi Kleen
2010-11-15 11:18 ` Stephane Eranian
2010-11-15 11:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115110608.GE7269@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox