Re: [PATCH 1/2] tracing,mm - add kernel pagefault tracepoint for x86 & x86_64

Andi Kleen
2010-11-10T16:28:10Z

On Wed, Nov 10, 2010 at 10:20:02AM -0500, Christoph Hellwig wrote:
> On Wed, Nov 10, 2010 at 04:17:50PM +0100, Jiri Olsa wrote:
> > I guess I can take the regs out then.. would that patch be acceptable
> > afterwards..?
>
> I really can't make much sense out of this whole trace point. What
> use it the task_struct address for example?
>
> What would be much more interesting is telling us if we had a
> major/minor fault, if ->page_mkwrite was called, etc.

Also on x86 I would log the error code.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.