public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
	lethal@linux-sh.org, g.liakhovetski@gmx.de,
	linux-sh@vger.kernel.org
Subject: [PATCH 01/05] fbdev: sh_mipi_dsi: Remove request/release mem region
Date: Wed, 17 Nov 2010 15:44:15 +0900	[thread overview]
Message-ID: <20101117064415.18139.28996.sendpatchset@t400s> (raw)
In-Reply-To: <20101117064405.18139.57035.sendpatchset@t400s>

From: Magnus Damm <damm@opensource.se>

The driver core already manages resources for us, so
there is no need to perform request_mem_region() and
release_mem_region() in the MIPI-DSI driver.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 drivers/video/sh_mipi_dsi.c |   11 -----------
 1 file changed, 11 deletions(-)

--- 0001/drivers/video/sh_mipi_dsi.c
+++ work/drivers/video/sh_mipi_dsi.c	2010-11-16 17:34:08.000000000 +0900
@@ -344,12 +344,6 @@ static int __init sh_mipi_probe(struct p
 		goto ealloc;
 	}
 
-	if (!request_mem_region(res->start, resource_size(res), pdev->name)) {
-		dev_err(&pdev->dev, "MIPI register region already claimed\n");
-		ret = -EBUSY;
-		goto ereqreg;
-	}
-
 	mipi->base = ioremap(res->start, resource_size(res));
 	if (!mipi->base) {
 		ret = -ENOMEM;
@@ -433,8 +427,6 @@ esettrate:
 eclktget:
 	iounmap(mipi->base);
 emap:
-	release_mem_region(res->start, resource_size(res));
-ereqreg:
 	kfree(mipi);
 ealloc:
 efindslot:
@@ -446,7 +438,6 @@ efindslot:
 static int __exit sh_mipi_remove(struct platform_device *pdev)
 {
 	struct sh_mipi_dsi_info *pdata = pdev->dev.platform_data;
-	struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	struct sh_mipi *mipi = platform_get_drvdata(pdev);
 	int i, ret;
 
@@ -476,8 +467,6 @@ static int __exit sh_mipi_remove(struct 
 	clk_put(mipi->dsit_clk);
 	clk_put(mipi->dsip_clk);
 	iounmap(mipi->base);
-	if (res)
-		release_mem_region(res->start, resource_size(res));
 	platform_set_drvdata(pdev, NULL);
 	kfree(mipi);
 

  reply	other threads:[~2010-11-17  6:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  6:44 [PATCH 00/05] fbdev: SH-Mobile MIPI-DSI Update Magnus Damm
2010-11-17  6:44 ` Magnus Damm [this message]
2010-11-17  7:25   ` [PATCH 01/05] fbdev: sh_mipi_dsi: Remove request/release mem region Paul Mundt
2010-11-17  8:51     ` Magnus Damm
2010-11-17  9:30       ` Paul Mundt
2010-11-17 10:06         ` Magnus Damm
2010-11-17  6:44 ` [PATCH 02/05] fbdev: sh_mipi_dsi: Make use of register names Magnus Damm
2010-11-17  6:44 ` [PATCH 03/05] ARM: mach-shmobile: Extend AP4EVB MIPI-DSI resources Magnus Damm
2010-11-17  6:44 ` [PATCH 04/05] fbdev: sh_mipi_dsi: Require two I/O resources Magnus Damm
2010-11-17  6:44 ` [PATCH 05/05] fbdev: sh_mipi_dsi: Allow LCDC board callbacks Magnus Damm
2010-11-17  7:48 ` [PATCH 00/05] fbdev: SH-Mobile MIPI-DSI Update Guennadi Liakhovetski
2010-11-19  8:05 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117064415.18139.28996.sendpatchset@t400s \
    --to=magnus.damm@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox