From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
chatty@enac.fr, spbnick@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile
Date: Tue, 16 Nov 2010 23:21:17 -0800 [thread overview]
Message-ID: <20101117072117.GC7046@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTikKTLpzafaE9oxRz1f_ZE9zv1eL6K8aAkYmR+TB@mail.gmail.com>
On Tue, Nov 16, 2010 at 10:28:19PM -0500, Tracey Dent wrote:
> On 11/15/10, Jiri Kosina <jkosina@suse.cz> wrote:
> > On Sun, 7 Nov 2010, Tracey Dent wrote:
> >
> >> Changed Makefile to use <modules>-y instead of <modules>-objs because
> >> -objs is deprecated and should now be switched. According to
> >> (documentation/kbuild/makefiles.txt).
> >
> > Actually, where exactly does this file document it?
> >
>
> It documents how it should be done in the section entitled --- 3.7
> Compilation flags (which starts on line 284).
>
Actually the only reference I could find is in 3.3:
If a kernel module is built from several source files, you specify
that you want to build a module in the same way as above; however,
kbuild needs to know which object files you want to build your
module from, so you have to tell it by setting a $(<module_name>-y)
variable.
See commit 4f8272802739f5c6ce6b0a548810a181d2f1b652 for reasoning behind
the change.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-11-17 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 14:46 [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile Tracey Dent
2010-11-07 14:46 ` [PATCH 2/2] Drivers: hid: usbhid: " Tracey Dent
2010-11-17 6:07 ` Américo Wang
2010-11-15 14:58 ` [PATCH 1/2] Drivers: hid: " Jiri Kosina
2010-11-17 3:28 ` Tracey Dent
2010-11-17 7:21 ` Dmitry Torokhov [this message]
2010-11-17 18:18 ` Tracey Dent
2010-11-17 6:05 ` Américo Wang
-- strict thread matches above, loose matches on Subject: below --
2010-11-06 19:07 Tracey Dent
2010-11-06 19:57 ` Dmitry Torokhov
2010-11-06 20:51 ` Tracey Dent
2010-11-07 5:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117072117.GC7046@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spbnick@gmail.com \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox