From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Marcus Meissner <meissner@suse.de>,
tglx@linutronix.de, mingo@elte.hu, rusty@rustcorp.com.au,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/time: Make /proc/timer_list mode 0400
Date: Wed, 17 Nov 2010 12:30:39 -0800 [thread overview]
Message-ID: <20101117123039.d975aa70.akpm@linux-foundation.org> (raw)
In-Reply-To: <1290014312.2109.1065.camel@laptop>
On Wed, 17 Nov 2010 18:18:32 +0100
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Wed, 2010-11-17 at 18:08 +0100, Marcus Meissner wrote:
> > Hi,
> >
> > /proc/timer_list contains kernel addresses, like e.g.:
> > #0: <c000000001404158>, tick_sched_timer, S:01, .tick_nohz_restart_sched_tick, swapper/0
> > ...
> >
> > Avoid leaking them to user space to make writing kernel exploits a bit harder.
> >
> > (I currently cannot think of a userland tool that uses this, this is
> > likely pretty much root-only.)
>
> iirc powertop parses this..
I bet it doesn't look at the kernel address (why was that added in the
first place, anyway?)
I'd suggest that the risk of breakage would be much less if we left the
file permissions alone and arranged for those addresses to be
0000000000000000 for non-root readers.
next prev parent reply other threads:[~2010-11-17 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 17:08 [PATCH] kernel/time: Make /proc/timer_list mode 0400 Marcus Meissner
2010-11-17 17:18 ` Peter Zijlstra
2010-11-17 17:21 ` Marcus Meissner
2010-11-17 17:33 ` Peter Zijlstra
2010-11-30 19:21 ` Pavel Machek
2010-11-17 20:30 ` Andrew Morton [this message]
2010-11-17 20:37 ` Thomas Gleixner
2010-11-18 8:12 ` Ingo Molnar
2010-11-18 8:28 ` Eric Dumazet
2010-11-30 19:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117123039.d975aa70.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox