From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()
Date: Wed, 17 Nov 2010 13:32:13 +0000 [thread overview]
Message-ID: <20101117133213.GJ3338@sirena.org.uk> (raw)
In-Reply-To: <20101117081205.GB11542@pengutronix.de>
On Wed, Nov 17, 2010 at 09:12:05AM +0100, Wolfram Sang wrote:
> On Wed, Nov 17, 2010 at 11:00:44AM +0800, Axel Lin wrote:
> > Regulators need to be available early in init in order to allow them
> > to be available for consumers when requested.
> > Other regulator drivers are already moved to subsys_initcall(),
> > looks like only lp3971 is missing.
> My 2 cents: it is safer to create such patches with real HW when there is a
> need (we deal with a similar situation in i2c). Janitorial might do more harm
> than good. Another option might be to call the patch a RFC?
Essentially any regulator driver has this requirement, it's just
something that was missed in the review when the patch was merged.
Grant has an idea for dealing with this differently by postpoing
registraton of dependant devices but for now all regulator drivers
should be registered early.
next prev parent reply other threads:[~2010-11-17 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 3:00 [PATCH] regulator: Move lp3971 regulator driver to subsys_initcall() Axel Lin
2010-11-17 8:12 ` Wolfram Sang
2010-11-17 8:21 ` Axel Lin
2010-11-17 13:32 ` Mark Brown [this message]
2010-11-17 13:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117133213.GJ3338@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox