From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: torvalds <torvalds@linux-foundation.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: BKL: remove extraneous #include <smp_lock.h>
Date: Wed, 17 Nov 2010 14:05:26 -0800 [thread overview]
Message-ID: <20101117140526.d532b373.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201011172159.oAHLx1tu001236@hera.kernel.org>
On Wed, 17 Nov 2010 21:59:01 GMT Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/linus/451a3c24b0135bce54542009b5fde43846c7cf67
> Commit: 451a3c24b0135bce54542009b5fde43846c7cf67
> Parent: 55f6561c6941713ab5ae9180525b026dd40b7d14
> Author: Arnd Bergmann <arnd@arndb.de>
> AuthorDate: Wed Nov 17 16:26:55 2010 +0100
> Committer: Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Wed Nov 17 08:59:32 2010 -0800
>
> BKL: remove extraneous #include <smp_lock.h>
>
> The big kernel lock has been removed from all these files at some point,
> leaving only the #include.
>
> Remove this too as a cleanup.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
causes build errors in linux-next of NOV. 17.
see http://lkml.org/lkml/2010/11/17/339
and http://lkml.org/lkml/2010/11/17/365
smp_lock.h was removed from hardirq.h. smp_lock.h provided the function prototype
for kernel_locked(). Should source files now #include <linux/smp_lock.h> ?
even when not being built for SMP?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next parent reply other threads:[~2010-11-17 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201011172159.oAHLx1tu001236@hera.kernel.org>
2010-11-17 22:05 ` Randy Dunlap [this message]
2010-11-17 22:23 ` BKL: remove extraneous #include <smp_lock.h> Linus Torvalds
2010-11-17 22:37 ` Randy Dunlap
2010-11-17 22:43 ` Arnd Bergmann
2010-11-18 9:43 ` [build failure] " Ingo Molnar
2010-11-18 15:57 ` Linus Torvalds
2010-11-18 16:02 ` Linus Torvalds
2010-11-18 16:28 ` Randy Dunlap
2010-11-18 19:02 ` Ingo Molnar
2010-11-18 19:04 ` Randy Dunlap
2010-11-18 19:44 ` Linus Torvalds
2010-11-18 19:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117140526.d532b373.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox