From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Jeff Garzik <jeff@garzik.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] libata: remove unlock+relock cycle in ata_scsi_queuecmd
Date: Wed, 17 Nov 2010 10:47:41 -0500 [thread overview]
Message-ID: <20101117154741.GA16768@infradead.org> (raw)
In-Reply-To: <1290007719.4736.9.camel@mulgrave.site>
> Right ... I couldn't persuade anyone else to do it, so I'll probably end
> up coding it. It looks like the serial number zero check might be
> bogus. If so I'll remove it, then push the serial number acquisition
> down only into the locked queuecommand of only those drivers that
> actually use it (which were listed in the quoted email, and which might
> have a big impetus to remove it if the use is trivial). Then we can
> begin unwinding the locking.
In dc395x, eata_pio, in2000, lpfc, megaraid_legacy, megaraid_mbox,
megaraid_sas, mesh, ncr53c8xx, qla1280, qla4xxx, wd33c93 and i2o_scsi
use it in printks only, and all this can be safely removed.
Except for EH that only leaves dpt_i2o, eata, mpt2sas, u14-34f, mptscsi
as non-trivial users. If you sort out the EH side I'll volunteer to
kill the printks and add private serial numbers to the five drivers
mentioned above.
next prev parent reply other threads:[~2010-11-17 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 6:29 [PATCH] libata: remove unlock+relock cycle in ata_scsi_queuecmd Jeff Garzik
2010-11-17 6:44 ` Linus Torvalds
2010-11-17 8:08 ` Jeff Garzik
2010-11-17 8:13 ` Jeff Garzik
2010-11-17 10:01 ` Tejun Heo
2010-11-17 15:11 ` Jeff Garzik
2010-11-17 15:28 ` James Bottomley
2010-11-17 15:47 ` Christoph Hellwig [this message]
2010-11-17 16:11 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117154741.GA16768@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@suse.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox