From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] sst: Construct fw string name runtime
Date: Wed, 17 Nov 2010 15:58:59 +0000 [thread overview]
Message-ID: <20101117155856.21681.87271.stgit@localhost.localdomain> (raw)
In-Reply-To: <20101117155748.21681.71501.stgit@localhost.localdomain>
From: Vinod Koul <vinod.koul@intel.com>
The firmware name for each platform is appended by PCI id of device.
This patch makes use of pci id to construct the string rather than
hardcode the string.
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/staging/intel_sst/intel_sst_common.h | 3 +--
.../staging/intel_sst/intel_sst_drv_interface.c | 11 ++++++-----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/intel_sst/intel_sst_common.h b/drivers/staging/intel_sst/intel_sst_common.h
index a828824..e0c6339 100644
--- a/drivers/staging/intel_sst/intel_sst_common.h
+++ b/drivers/staging/intel_sst/intel_sst_common.h
@@ -33,10 +33,9 @@
/* driver names */
#define SST_DRV_NAME "intel_sst_driver"
-#define SST_FW_FILENAME_MRST "fw_sst_080a.bin"
-#define SST_FW_FILENAME_MFLD "fw_sst_082f.bin"
#define SST_MRST_PCI_ID 0x080A
#define SST_MFLD_PCI_ID 0x082F
+#define PCI_ID_LENGTH 4
#define SST_SUSPEND_DELAY 2000
enum sst_states {
diff --git a/drivers/staging/intel_sst/intel_sst_drv_interface.c b/drivers/staging/intel_sst/intel_sst_drv_interface.c
index 1ff6420..eeae06d 100644
--- a/drivers/staging/intel_sst/intel_sst_drv_interface.c
+++ b/drivers/staging/intel_sst/intel_sst_drv_interface.c
@@ -46,13 +46,14 @@ int sst_download_fw(void)
{
int retval;
const struct firmware *fw_sst;
- const char *name;
+ char name[20];
+
if (sst_drv_ctx->sst_state != SST_UN_INIT)
return -EPERM;
- if (sst_drv_ctx->pci_id == SST_MRST_PCI_ID)
- name = SST_FW_FILENAME_MRST;
- else
- name = SST_FW_FILENAME_MFLD;
+
+ snprintf(name, sizeof(name), "%s%04x%s", "fw_sst_",
+ sst_drv_ctx->pci_id, ".bin");
+
pr_debug("sst: Downloading %s FW now...\n", name);
retval = request_firmware(&fw_sst, name, &sst_drv_ctx->pci->dev);
if (retval) {
next prev parent reply other threads:[~2010-11-17 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 15:57 [PATCH 1/7] sst: remove rest of aava bits and aava related code Alan Cox
2010-11-17 15:58 ` [PATCH 2/7] sst: Change the SST driver PCM interface Alan Cox
2010-11-17 15:58 ` [PATCH 3/7] sst: Add runtime PM support Alan Cox
2010-11-17 15:58 ` Alan Cox [this message]
2010-11-17 15:59 ` [PATCH 5/7] sst: Firmware error codes force number values Alan Cox
2010-11-17 15:59 ` [PATCH 6/7] sst: log error returned by scu ipc read/write Alan Cox
2010-11-17 15:59 ` [PATCH 7/7] sst: add ioctls for post processing algorithm interface Alan Cox
2010-11-17 21:18 ` [PATCH 1/7] sst: remove rest of aava bits and aava related code Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117155856.21681.87271.stgit@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox