From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>, Lin Ming <ming.m.lin@intel.com>,
Stephane Eranian <eranian@google.com>,
"robert.richter" <robert.richter@amd.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
fweisbec <fweisbec@gmail.com>, paulus <paulus@samba.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Kyle Moffett <kyle@moffetthome.net>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [RFC][PATCH 4/8] perf: Use early_initcall() for tracepoint and breakpoint init
Date: Wed, 17 Nov 2010 23:17:34 +0100 [thread overview]
Message-ID: <20101117222056.150176439@chello.nl> (raw)
In-Reply-To: 20101117221730.002627458@chello.nl
[-- Attachment #1: perf-fix-tp-bp-init.patch --]
[-- Type: text/plain, Size: 1580 bytes --]
Just like other pmu implementations, use early_initcall().
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/hw_breakpoint.c | 2 +-
kernel/perf_event.c | 9 +++------
2 files changed, 4 insertions(+), 7 deletions(-)
Index: linux-2.6/kernel/hw_breakpoint.c
===================================================================
--- linux-2.6.orig/kernel/hw_breakpoint.c
+++ linux-2.6/kernel/hw_breakpoint.c
@@ -655,6 +655,6 @@ static int __init init_hw_breakpoint(voi
return -ENOMEM;
}
-core_initcall(init_hw_breakpoint);
+early_initcall(init_hw_breakpoint);
Index: linux-2.6/kernel/perf_event.c
===================================================================
--- linux-2.6.orig/kernel/perf_event.c
+++ linux-2.6/kernel/perf_event.c
@@ -4831,10 +4831,12 @@ static struct pmu perf_tracepoint = {
.read = perf_swevent_read,
};
-static inline void perf_tp_register(void)
+static __init int perf_tp_init(void)
{
perf_pmu_register(&perf_tracepoint);
+ return 0;
}
+early_initcall(perf_tp_init);
static int perf_event_set_filter(struct perf_event *event, void __user *arg)
{
@@ -4861,10 +4863,6 @@ static void perf_event_free_filter(struc
#else
-static inline void perf_tp_register(void)
-{
-}
-
static int perf_event_set_filter(struct perf_event *event, void __user *arg)
{
return -ENOENT;
@@ -6365,6 +6363,5 @@ void __init perf_event_init(void)
perf_pmu_register(&perf_swevent);
perf_pmu_register(&perf_cpu_clock);
perf_pmu_register(&perf_task_clock);
- perf_tp_register();
perf_cpu_notifier(perf_cpu_notify);
}
next prev parent reply other threads:[~2010-11-17 22:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 22:17 [RFC][PATCH 0/8] perf sysfs bits Peter Zijlstra
2010-11-17 22:17 ` [RFC][PATCH 1/8] perf, x86: Fixup Kconfig deps Peter Zijlstra
2010-11-26 15:01 ` [tip:perf/core] " tip-bot for Peter Zijlstra
2010-11-17 22:17 ` [RFC][PATCH 2/8] perf, arch: Use early_initcall() for all arch pmu implementations Peter Zijlstra
2010-11-25 10:25 ` Peter Zijlstra
2010-11-25 14:47 ` Peter Zijlstra
2010-11-25 16:22 ` Will Deacon
2010-11-25 16:34 ` Peter Zijlstra
2010-11-25 17:55 ` Peter Zijlstra
2010-11-26 7:13 ` Paul Mundt
2010-11-26 9:41 ` Will Deacon
2010-11-26 15:05 ` [tip:perf/core] perf, arch: Cleanup perf-pmu init vs lockup-detector tip-bot for Peter Zijlstra
2010-11-17 22:17 ` [RFC][PATCH 3/8] perf: Move perf_event_init() into main.c Peter Zijlstra
2010-12-16 12:32 ` [tip:perf/core] " tip-bot for Peter Zijlstra
2010-11-17 22:17 ` Peter Zijlstra [this message]
2010-11-17 22:17 ` [RFC][PATCH 5/8] init: Initialized IRD earlier Peter Zijlstra
2010-12-16 12:32 ` [tip:perf/core] init: Initialized IDR earlier tip-bot for Peter Zijlstra
2010-11-17 22:17 ` [RFC][PATCH 6/8] perf: Dynamic pmu types Peter Zijlstra
2010-12-16 12:32 ` [tip:perf/core] " tip-bot for Peter Zijlstra
2010-11-17 22:17 ` [RFC][PATCH 7/8] perf: Sysfs enumeration Peter Zijlstra
2010-12-16 12:33 ` [tip:perf/core] " tip-bot for Peter Zijlstra
2010-11-17 22:17 ` [RFC][PATCH 8/8] perf: Sysfs events Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117222056.150176439@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=kay.sievers@vrfy.org \
--cc=kyle@moffetthome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox