Re: [PATCH] ASoC: Add support for MAX98089 CODEC

Mark Brown
2010-11-18T11:07:34Z

On Wed, Nov 17, 2010 at 02:26:40PM -0600, Jesse Marroquin wrote:
> This patch adds initial support for the MAX98089 CODEC.

Applied, thanks. One thing:

> struct max98088_priv {
> u8 reg_cache[M98088_REG_CNT];
> + enum max98088_type devtype;

You currently never actually read the devtype anywhere - if the devices
really are fully register compatible (eg, if the differences are in
physical or electrical characteristics which aren't visible to software)
then there's no need to bother doing this, though equally well it does
no harm.