Re: [PATCH 1/2] perf: Fix compilation on gcc 4.0.2

Eric Dumazet
2010-11-18T13:38:35Z

Le jeudi 18 novembre 2010 à 14:31 +0100, Andi Kleen a écrit :
> > Should we be using more of the kernel makefile magic to detect this?
>
> In theory yes, but the two warnings didn't seem to be too useful
> to me so it's probably not worth it just for those two.
>
> -Andi
>

Is the second case because of the __always_inline in
util/include/linux/bitops.h ?

Not sure why its needed for test_bit() ?

diff --git a/tools/perf/util/include/linux/bitops.h b/tools/perf/util/include/linux/bitops.h
index bb4ac2e..a1459f2 100644
--- a/tools/perf/util/include/linux/bitops.h
+++ b/tools/perf/util/include/linux/bitops.h
@@ -13,7 +13,7 @@ static inline void set_bit(int nr, unsigned long *addr)
addr[nr / BITS_PER_LONG] |= 1UL << (nr % BITS_PER_LONG);
}

-static __always_inline int test_bit(unsigned int nr, const unsigned long *addr)
+static inline int test_bit(unsigned int nr, const unsigned long *addr)
{
return ((1UL << (nr % BITS_PER_LONG)) &
(((unsigned long *)addr)[nr / BITS_PER_LONG])) != 0;