Re: [PATCH 1/2] perf: Fix compilation on gcc 4.0.2

Andi Kleen
2010-11-18T13:40:42Z

On Thu, Nov 18, 2010 at 02:38:09PM +0100, Eric Dumazet wrote:
> Le jeudi 18 novembre 2010 à 14:31 +0100, Andi Kleen a écrit :
> > > Should we be using more of the kernel makefile magic to detect this?
> >
> > In theory yes, but the two warnings didn't seem to be too useful
> > to me so it's probably not worth it just for those two.
> >
> > -Andi
> >
>
> Is the second case because of the __always_inline in
> util/include/linux/bitops.h ?

I think so.

>
> Not sure why its needed for test_bit() ?

Because it generates terrible code when not inlined
and apparently some gcc versions of times past didn't
in some cases.

-Andi