public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.linux-foundation.org>
Subject: Re: 2.6.37-rc1+: hibernate regression, claims not enough swap space
Date: Thu, 18 Nov 2010 13:43:00 +0100	[thread overview]
Message-ID: <201011181343.00978.rjw@sisk.pl> (raw)
In-Reply-To: <20101117233859.GA23086@elf.ucw.cz>

On Thursday, November 18, 2010, Pavel Machek wrote:
> Hi!
> 
> > > > This is not how it works now.  We preallocate memory to create memory pressure,
> > > > so if image_size is 0, we need to preallocate until we run out of pages that
> > > > can be freed, which means OOM.
> > > 
> > > That's bad, right? Instead of killing 
> > 
> > I'm not sure what you mean.
> 
> I meant "instead of failing hibernation, you get OOM -- killing random
> processes".

That's not the case.  The OOM _killer_ is disabled during hibernation, but
there's some more OOM code that's trying very hard to free whatever pages
it can get without killing any processes.

> > > Anyway, it does not work at all.
> > > 
> > > root@amd:~# echo 300000000 > /sys/power/image_size
> > > root@amd:~# echo disk > /sys/power/state 
> > > -su: echo: write error: No space left on device
> > > 
> > > (And dmesg full of failed allocations).
> > > 
> > > I can write 400M there, and it fails, too.
> > 
> > Well, in that case your swap is smaller than the requested image size, isn't it?
> 
> No, swap is 
> 
> pavel@amd:~/misc$ cat /proc/swaps 
> Filename				Type		Size	Used
> Priority
> /dev/sda1                               partition	779148	0
> -1
> 
> ... 700M.
> 
> > There's a check in there that should catch that and it apparently doesn't work.
> > 
> > Do you have that dmesg by chance?
> 
> dmesg is useless -- it is full of backtraces :-(. ACPI allocations
> fail.

What about:

# echo core > /sys/power/pm_test
# echo disk > /sys/power/state

Then the messages should be there in the logs.

Thanks,
Rafael

      reply	other threads:[~2010-11-18 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14  5:21 2.6.37-rc1+: hibernate regression, claims not enough swap space Pavel Machek
2010-11-15 22:26 ` Rafael J. Wysocki
2010-11-16  5:26   ` Pavel Machek
2010-11-16  5:32     ` Pavel Machek
2010-11-16 22:28       ` Rafael J. Wysocki
2010-11-16 22:27     ` Rafael J. Wysocki
2010-11-17 21:19       ` Pavel Machek
2010-11-17 23:18         ` Rafael J. Wysocki
2010-11-17 23:38           ` Pavel Machek
2010-11-18 12:43             ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011181343.00978.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox