[PATCH 1/2] uml: Safely iterate list of winch handlers in line driver.

[PATCH 1/2] uml: Safely iterate list of winch handlers in line driver.

[Will Newton]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

unregister_winch should use list_for_each_safe, as it can
potentially delete from the list.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 arch/um/drivers/line.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index 7f7338c..5f12fef 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -820,12 +820,12 @@ void register_winch_irq(int fd, int tty_fd, int
pid, struct tty_struct *tty,

 static void unregister_winch(struct tty_struct *tty)
 {
-	struct list_head *ele;
+	struct list_head *ele, *next;
 	struct winch *winch;

 	spin_lock(&winch_handler_lock);

-	list_for_each(ele, &winch_handlers) {
+	list_for_each_safe(ele, next, &winch_handlers) {
 		winch = list_entry(ele, struct winch, list);
 		if (winch->tty == tty) {
 			free_winch(winch, 1);
-- 
1.7.0.4

[-- Attachment #2: 0001-uml-Safely-iterate-list-of-winch-handlers-in-line-dr.patch --]
[-- Type: text/x-patch, Size: 1098 bytes --]

From e579eb5835a0730177388545520f21d9fbc0de1e Mon Sep 17 00:00:00 2001
From: Will Newton <will.newton@gmail.com>
Date: Sat, 13 Nov 2010 16:30:58 +0000
Subject: [PATCH 1/2] uml: Safely iterate list of winch handlers in line driver.

unregister_winch should use list_for_each_safe, as it can
potentially delete from the list.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 arch/um/drivers/line.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index 7f7338c..5f12fef 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -820,12 +820,12 @@ void register_winch_irq(int fd, int tty_fd, int pid, struct tty_struct *tty,
 
 static void unregister_winch(struct tty_struct *tty)
 {
-	struct list_head *ele;
+	struct list_head *ele, *next;
 	struct winch *winch;
 
 	spin_lock(&winch_handler_lock);
 
-	list_for_each(ele, &winch_handlers) {
+	list_for_each_safe(ele, next, &winch_handlers) {
 		winch = list_entry(ele, struct winch, list);
 		if (winch->tty == tty) {
 			free_winch(winch, 1);
-- 
1.7.0.4

Re: [PATCH 1/2] uml: Safely iterate list of winch handlers in line driver.

[richard -rw- weinberger]

On Sat, Nov 13, 2010 at 6:44 PM, Will Newton <will.newton@gmail.com> wrote:
> unregister_winch should use list_for_each_safe, as it can
> potentially delete from the list.
>
> Signed-off-by: Will Newton <will.newton@gmail.com>
> ---
>  arch/um/drivers/line.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
> index 7f7338c..5f12fef 100644
> --- a/arch/um/drivers/line.c
> +++ b/arch/um/drivers/line.c
> @@ -820,12 +820,12 @@ void register_winch_irq(int fd, int tty_fd, int
> pid, struct tty_struct *tty,
>
>  static void unregister_winch(struct tty_struct *tty)
>  {
> -       struct list_head *ele;
> +       struct list_head *ele, *next;
>        struct winch *winch;
>
>        spin_lock(&winch_handler_lock);
>
> -       list_for_each(ele, &winch_handlers) {
> +       list_for_each_safe(ele, next, &winch_handlers) {
>                winch = list_entry(ele, struct winch, list);
>                if (winch->tty == tty) {
>                        free_winch(winch, 1);
> --
> 1.7.0.4
>

Please send your patches to akpm.

-- 
Thanks,
//richard

Re: [PATCH 1/2] uml: Safely iterate list of winch handlers in line driver.

[Américo Wang]

On Sat, Nov 13, 2010 at 05:44:28PM +0000, Will Newton wrote:
>unregister_winch should use list_for_each_safe, as it can
>potentially delete from the list.
>
>Signed-off-by: Will Newton <will.newton@gmail.com>

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Andrew Morton

Thanks.