From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH 1/3] x86: only call smp_processor_id in non-preempt cases
Date: Thu, 18 Nov 2010 09:22:13 -0500 [thread overview]
Message-ID: <20101118142213.GB18100@redhat.com> (raw)
In-Reply-To: <20101118081407.GB23481@elte.hu>
On Thu, Nov 18, 2010 at 09:14:07AM +0100, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > There are some paths that walk the die_chain with preemption on.
>
> What are those codepaths? At minimum it's worth documenting them.
Well the one that caused the bug was do_general_protection which walks the
die_chain with DIE_GPF.
I can document them, though it might be time consuming to audit them and
hope they don't change. I guess my bigger question is, is it expected
that anyone who calls the die_chain to have preemption disabled? If not,
then does it matter if we document it?
Cheers,
Don
next prev parent reply other threads:[~2010-11-18 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 14:50 [PATCH 1/3] x86: only call smp_processor_id in non-preempt cases Don Zickus
2010-11-12 14:50 ` [PATCH 2/3] x86, hw_nmi: Move backtrace_mask declaration under ARCH_HAS_NMI_WATCHDOG Don Zickus
2010-11-12 14:50 ` [PATCH 3/3] x86: Avoid calling arch_trigger_all_cpu_backtrace() at the same time Don Zickus
2010-11-18 15:57 ` Frederic Weisbecker
2010-11-19 3:00 ` DDD
2010-11-18 8:14 ` [PATCH 1/3] x86: only call smp_processor_id in non-preempt cases Ingo Molnar
2010-11-18 14:22 ` Don Zickus [this message]
2010-11-18 14:49 ` Ingo Molnar
2010-11-18 15:35 ` Don Zickus
-- strict thread matches above, loose matches on Subject: below --
2011-01-05 3:38 [PATCH 1/3] x86: Only " Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118142213.GB18100@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox