Re: [PATCH] Make swap accounting default behavior configurable

Andrew Morton
2010-11-17T01:16:06Z

On Wed, 17 Nov 2010 09:23:39 +0900 Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> > >
> > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > > index ed45e98..14eafa5 100644
> > > --- a/Documentation/kernel-parameters.txt
> > > +++ b/Documentation/kernel-parameters.txt
> > > @@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file
> > > improve throughput, but will also increase the
> > > amount of memory reserved for use by the client.
> > >
> > > + swapaccount [KNL] Enable accounting of swap in memory resource
> > > + controller. (See Documentation/cgroups/memory.txt)
> >
> > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]"
> > would have been better.
> >
> I suggested to keep "noswapaccount" for compatibility.
> If you and other guys don't like having two parameters, I don't stick to
> the old parameter.
>

Yes, we're stuck with the old one now.

But we should note that "foo=[0|1]" is superior to "foo" and "nofoo".
Even if we didn't initially intend to add "nofoo".