From: Joel Becker <Joel.Becker@oracle.com>
To: Milton Miller <miltonm@bga.com>
Cc: Tao Ma <tao.ma@oracle.com>,
ocfs2-devel@oss.oracle.com, Mark Fasheh <mfasheh@suse.com>,
linux-kernel@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.de>
Subject: Re: ocfs2: char is not always signed
Date: Thu, 18 Nov 2010 15:43:43 -0800 [thread overview]
Message-ID: <20101118234343.GK19821@mail.oracle.com> (raw)
In-Reply-To: <1290054011_17741@mail4.comsite.net>
On Wed, Nov 17, 2010 at 10:20:11PM -0600, Milton Miller wrote:
> Commit 1c66b360fe262 (Change some lock status member in ocfs2_lock_res
> to char.) states that these fields need to be signed due to comparision
> to -1, but only changed the type from unsigned char to char. However, it
> is a compiler option if char is a signed or unsigned type. Change these
> fields to signed char so the code will work with all compilers.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
This patch is now in the fixes branch of ocfs2.git.
Joel
--
"This is the end, beautiful friend.
This is the end, my only friend the end
Of our elaborate plans, the end
Of everything that stands, the end
No safety or surprise, the end
I'll never look into your eyes again."
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2010-11-18 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 4:20 ocfs2: char is not always signed Milton Miller
2010-11-18 5:40 ` Tao Ma
2010-11-18 23:43 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118234343.GK19821@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=miltonm@bga.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rgoldwyn@suse.de \
--cc=tao.ma@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox