From: Alan Cox <alan@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Liu Hong <hong.liu@intel.com>,
Kalhan Trisal <kalhan.trisal@intel.com>
Subject: Re: [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove()
Date: Fri, 19 Nov 2010 10:46:31 +0000 [thread overview]
Message-ID: <20101119104631.2c28da00@linux.intel.com> (raw)
In-Reply-To: <1290144437.23599.4.camel@mola>
On Fri, 19 Nov 2010 13:27:17 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> struct als_data *data is not used in this driver at all.
>
> Also add a missing ">" character for MODULE_AUTHOR.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
It stayed as NULL so the kfree was fine but it definitely wants removing
prev parent reply other threads:[~2010-11-19 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 5:27 [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove() Axel Lin
2010-11-19 10:46 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119104631.2c28da00@linux.intel.com \
--to=alan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=hong.liu@intel.com \
--cc=kalhan.trisal@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox