* [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove()
@ 2010-11-19 5:27 Axel Lin
2010-11-19 10:46 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-11-19 5:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Alan Cox, Liu Hong, Kalhan Trisal
struct als_data *data is not used in this driver at all.
Also add a missing ">" character for MODULE_AUTHOR.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/misc/isl29020.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/isl29020.c b/drivers/misc/isl29020.c
index ca47e62..307aada 100644
--- a/drivers/misc/isl29020.c
+++ b/drivers/misc/isl29020.c
@@ -183,9 +183,7 @@ static int isl29020_probe(struct i2c_client *client,
static int isl29020_remove(struct i2c_client *client)
{
- struct als_data *data = i2c_get_clientdata(client);
sysfs_remove_group(&client->dev.kobj, &m_als_gr);
- kfree(data);
return 0;
}
@@ -245,6 +243,6 @@ static void __exit sensor_isl29020_exit(void)
module_init(sensor_isl29020_init);
module_exit(sensor_isl29020_exit);
-MODULE_AUTHOR("Kalhan Trisal <kalhan.trisal@intel.com");
+MODULE_AUTHOR("Kalhan Trisal <kalhan.trisal@intel.com>");
MODULE_DESCRIPTION("Intersil isl29020 ALS Driver");
MODULE_LICENSE("GPL v2");
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove()
2010-11-19 5:27 [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove() Axel Lin
@ 2010-11-19 10:46 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2010-11-19 10:46 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Andrew Morton, Liu Hong, Kalhan Trisal
On Fri, 19 Nov 2010 13:27:17 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> struct als_data *data is not used in this driver at all.
>
> Also add a missing ">" character for MODULE_AUTHOR.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
It stayed as NULL so the kfree was fine but it definitely wants removing
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-19 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-19 5:27 [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove() Axel Lin
2010-11-19 10:46 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox