From: Greg KH <gregkh@suse.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: base: core: do not put noninitialized devices
Date: Fri, 19 Nov 2010 11:02:42 -0800 [thread overview]
Message-ID: <20101119190242.GA14328@suse.de> (raw)
In-Reply-To: <1290192100-11451-1-git-send-email-segoon@openwall.com>
On Fri, Nov 19, 2010 at 09:41:40PM +0300, Vasiliy Kulikov wrote:
> If kobject_set_name_vargs() fails then put_device() frees
> device with zero kobj->state_initialized. This leads to WARN().
Have you seen this happen?
> Divide device_register() call to device_initialize() call before
> kobject_set_name_vargs() and device_add() call after it.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Compile tested only.
I'd prefer not to change this unless you are seeing problems with the
current code.
How did kobject_set_name_vargs() fail for you?
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-19 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 18:41 [PATCH] drivers: base: core: do not put noninitialized devices Vasiliy Kulikov
2010-11-19 19:02 ` Greg KH [this message]
2010-11-19 19:14 ` Vasiliy Kulikov
2010-11-19 19:17 ` Vasiliy Kulikov
2010-11-19 20:57 ` Greg KH
2010-11-20 9:00 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119190242.GA14328@suse.de \
--to=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox