public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: sep: Introduce sep driver
Date: Fri, 19 Nov 2010 17:43:33 -0800	[thread overview]
Message-ID: <20101120014333.GA15634@kroah.com> (raw)
In-Reply-To: <1290037536-12660-1-git-send-email-mark.a.allyn@intel.com>

On Wed, Nov 17, 2010 at 03:45:36PM -0800, Mark Allyn wrote:
> This driver is for the Security Processor, a dedicated encryption
> and decryption driver that is used on the Intel mobile platform.
> 
> This has been checked with checkpatch and there are four
> warnings for lines over 80 charactors.
> 
> There is one compile warning. This is for a function that is
> only used if the rar register driver is needed. There is an
> ifdef in a header file that stubs out the rar register driver
> if the rar register is not configured.
> 
> This driver does add a configuration, which is CONFIG_DX_SEP.

Also, this driver spits out a _lot_ of compiler warnings on x86-64.
Please fix that now before someone else starts yelling at you...

thanks,

greg k-h

  parent reply	other threads:[~2010-11-20  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 23:45 [PATCH 1/1] sep: Introduce sep driver Mark Allyn
2010-11-20  1:20 ` Greg KH
2010-11-20  1:43 ` Greg KH [this message]
2010-11-20 12:39 ` Alan Cox
2010-11-20 16:27   ` Greg KH
2010-11-21 14:07     ` Alan Cox
2010-11-21 17:21       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101120014333.GA15634@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.a.allyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox