* [PATCH] checkpatch: teach checkpatch about rcu
@ 2010-11-18 17:05 Michael S. Tsirkin
2010-11-18 17:15 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2010-11-18 17:05 UTC (permalink / raw)
To: Andy Whitcroft, Andrew Morton, Joe Perches, Patrick Pannuto,
Wolfram Sang, Hidetoshi Seto, linux-kernel
I got this:
+ struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
which is because checkpatch does not know about __rcu.
So here's a patch to teach it about that tag.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2039acd..1b11c8e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -143,6 +143,7 @@ our $Sparse = qr{
__must_check|
__init_refok|
__kprobes|
+ __rcu|
__ref
}x;
--
1.7.3.2.91.g446ac
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: teach checkpatch about rcu
2010-11-18 17:05 [PATCH] checkpatch: teach checkpatch about rcu Michael S. Tsirkin
@ 2010-11-18 17:15 ` Eric Dumazet
2010-11-21 8:31 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2010-11-18 17:15 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Andy Whitcroft, Andrew Morton, Joe Perches, Patrick Pannuto,
Wolfram Sang, Hidetoshi Seto, linux-kernel
Le jeudi 18 novembre 2010 à 19:05 +0200, Michael S. Tsirkin a écrit :
> I got this:
> + struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
> which is because checkpatch does not know about __rcu.
> So here's a patch to teach it about that tag.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> scripts/checkpatch.pl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2039acd..1b11c8e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -143,6 +143,7 @@ our $Sparse = qr{
> __must_check|
> __init_refok|
> __kprobes|
> + __rcu|
> __ref
> }x;
>
Hmm, why __percpu is in $Attribute, and __rcu in $Sparse ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: teach checkpatch about rcu
2010-11-18 17:15 ` Eric Dumazet
@ 2010-11-21 8:31 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2010-11-21 8:31 UTC (permalink / raw)
To: Eric Dumazet
Cc: Andy Whitcroft, Andrew Morton, Joe Perches, Patrick Pannuto,
Wolfram Sang, Hidetoshi Seto, linux-kernel
On Thu, Nov 18, 2010 at 06:15:47PM +0100, Eric Dumazet wrote:
> Le jeudi 18 novembre 2010 à 19:05 +0200, Michael S. Tsirkin a écrit :
> > I got this:
> > + struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
> > which is because checkpatch does not know about __rcu.
> > So here's a patch to teach it about that tag.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > scripts/checkpatch.pl | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 2039acd..1b11c8e 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -143,6 +143,7 @@ our $Sparse = qr{
> > __must_check|
> > __init_refok|
> > __kprobes|
> > + __rcu|
> > __ref
> > }x;
> >
>
>
> Hmm, why __percpu is in $Attribute, and __rcu in $Sparse ?
>
I can't say: we have __kernel and __user and __iomem address spaces in $Sparse
and only __percpu in $Attribute, so I thought address spaces belong in
$Sparse and __percpu just sneaked in there with a ton of other
attributes added by 03f1df7da5696ddfa6e167b37e0c0ce5aad3de79.
Should __percpu be moved to $Sparse perhaps?
--
MST
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-21 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-18 17:05 [PATCH] checkpatch: teach checkpatch about rcu Michael S. Tsirkin
2010-11-18 17:15 ` Eric Dumazet
2010-11-21 8:31 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox