public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: Alban Crequy <alban.crequy@collabora.co.uk>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] AF_UNIX: Documentation on multicast Unix Sockets
Date: Mon, 22 Nov 2010 21:07:40 +0200	[thread overview]
Message-ID: <201011222107.41548.remi@remlab.net> (raw)
In-Reply-To: <1290450982-17480-7-git-send-email-alban.crequy@collabora.co.uk>

Le lundi 22 novembre 2010 20:36:20 Alban Crequy, vous avez écrit :
> +Multicast Unix sockets
> +======================
> +
> +Multicast group memberships are stored in struct unix_mcast nodes. An Unix
> +socket can join several multicast groups. Struct unix_mcast nodes are
> doubly +linked:
> +- In (struct unix_sock)->mcast_subscriptions
> +- In (struct unix_sock)->mcast_members

I may be stupid, but I found this whole documentation very confusing, and so 
the API it tries to describe. Traditionally:
- Senders may or not may be part of the group and are not kept track of.
- Receivers join to the group then receive message sent to it.
- Loopback defines whether a sender receives its own echo if it sends to a
group that it has joined.
- If connected to a multicast group, messages from the socket are routed to 
the group (in absence of a contradictoy socket address). This has no effect on 
membership to the multicast group under any circumstance.

You cannot 'listen' or 'accept' on a multicast group.

So I am not entirely clear what semantics your patchset is following. But it 
does not seem like "multicast" to me and therefore seems not very well 
documented :-(

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis

  reply	other threads:[~2010-11-22 19:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 18:34 [PATCH 0/9] RFC v2: Multicast and filtering features on AF_UNIX Alban Crequy
2010-11-22 18:36 ` [PATCH 1/9] AF_UNIX: Add constant for Unix socket options level Alban Crequy
2010-11-22 18:36 ` [PATCH 2/9] AF_UNIX: add setsockopt on Unix sockets Alban Crequy
2010-11-22 18:36 ` [PATCH 3/9] AF_UNIX: create, join and leave multicast groups with setsockopt Alban Crequy
2010-11-22 19:00   ` David Miller
2010-11-22 18:36 ` [PATCH 4/9] AF_UNIX: find the recipients for multicast messages Alban Crequy
2010-11-22 19:05   ` David Miller
2010-11-23 15:03     ` Alban Crequy
2010-11-23 16:08       ` Eric Dumazet
2010-11-23 16:56         ` Eric Dumazet
2010-11-23 17:47         ` Alban Crequy
2010-11-23 18:39           ` David Miller
2010-11-22 20:14   ` Andi Kleen
2010-11-22 18:36 ` [PATCH 5/9] AF_UNIX: Deliver message to several recipients in case of multicast Alban Crequy
2010-11-22 18:36 ` [PATCH 6/9] AF_UNIX: Apply Linux Socket Filtering to Unix sockets Alban Crequy
2010-11-22 18:36 ` [PATCH 7/9] AF_UNIX: Documentation on multicast Unix Sockets Alban Crequy
2010-11-22 19:07   ` Rémi Denis-Courmont [this message]
2010-11-22 20:09     ` Alban Crequy
2010-11-22 18:36 ` [PATCH 8/9] AF_UNIX: add options on multicast connected socket Alban Crequy
2010-11-22 18:36 ` [PATCH 9/9] AF_UNIX: implement poll(POLLOUT) for multicast sockets Alban Crequy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011222107.41548.remi@remlab.net \
    --to=remi@remlab.net \
    --cc=alban.crequy@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox