From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Dave Martin <dave.martin@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Allow space before [ in the case of inline asm constraints
Date: Tue, 23 Nov 2010 14:32:17 +0000 [thread overview]
Message-ID: <20101123143217.GU6038@shadowen.org> (raw)
In-Reply-To: <1289919612.28741.58.camel@Joe-Laptop>
On Tue, Nov 16, 2010 at 07:00:12AM -0800, Joe Perches wrote:
> On Tue, 2010-11-16 at 12:13 +0000, Dave Martin wrote:
> > This allows the customary syntax for declaring named arguments,
> > such as:
> >
> > asm ("mov %[out],%[in]" : [out] "=r" (x) : [in] "r" (y));
>
> Andy:
>
> Maybe it'd be better to have a checkpatch pass that does
> something similar to the c comment removal for asm blocks.
>
> Maybe keyed on "\basm(\s+volatile){0,1}\s*" and strip
> everything in the () block that follows it.
Yeah am starting to think that whatever is in there is a different
world.
-apw
prev parent reply other threads:[~2010-11-23 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 12:13 [PATCH] checkpatch: Allow space before [ in the case of inline asm constraints Dave Martin
2010-11-16 15:00 ` Joe Perches
2010-11-23 14:32 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123143217.GU6038@shadowen.org \
--to=apw@canonical.com \
--cc=dave.martin@linaro.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox