From: Christoph Lameter <cl@linux.com>
To: akpm@linux-foundation.org
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Tejun Heo <tj@kernel.org>
Subject: [thiscpuops upgrade 04/10] x86: Support for this_cpu_add,sub,dec,inc_return
Date: Tue, 23 Nov 2010 17:51:43 -0600 [thread overview]
Message-ID: <20101123235158.236495885@linux.com> (raw)
In-Reply-To: 20101123235139.908255844@linux.com
[-- Attachment #1: this_cpu_add_x86 --]
[-- Type: text/plain, Size: 2865 bytes --]
Supply an implementation for x86 in order to generate more efficient code.
Signed-off-by: Christoph Lameter <cl@linux.com>
---
arch/x86/include/asm/percpu.h | 50 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
Index: linux-2.6/arch/x86/include/asm/percpu.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/percpu.h 2010-11-23 16:35:19.000000000 -0600
+++ linux-2.6/arch/x86/include/asm/percpu.h 2010-11-23 16:36:05.000000000 -0600
@@ -177,6 +177,45 @@ do { \
} \
} while (0)
+
+/*
+ * Add return operation
+ */
+#define percpu_add_return_op(var, val) \
+({ \
+ typedef typeof(var) pao_T__; \
+ typeof(var) pfo_ret__ = val; \
+ if (0) { \
+ pao_T__ pao_tmp__; \
+ pao_tmp__ = (val); \
+ (void)pao_tmp__; \
+ } \
+ switch (sizeof(var)) { \
+ case 1: \
+ asm("xaddb %0, "__percpu_arg(1) \
+ : "+q" (pfo_ret__), "+m" (var) \
+ : : "memory"); \
+ break; \
+ case 2: \
+ asm("xaddw %0, "__percpu_arg(1) \
+ : "+r" (pfo_ret__), "+m" (var) \
+ : : "memory"); \
+ break; \
+ case 4: \
+ asm("xaddl %0, "__percpu_arg(1) \
+ : "+r"(pfo_ret__), "+m" (var) \
+ : : "memory"); \
+ break; \
+ case 8: \
+ asm("xaddq %0, "__percpu_arg(1) \
+ : "+re" (pfo_ret__), "+m" (var) \
+ : : "memory"); \
+ break; \
+ default: __bad_percpu_size(); \
+ } \
+ pfo_ret__ + (val); \
+})
+
#define percpu_from_op(op, var, constraint) \
({ \
typeof(var) pfo_ret__; \
@@ -300,6 +339,14 @@ do { \
#define irqsafe_cpu_xor_2(pcp, val) percpu_to_op("xor", (pcp), val)
#define irqsafe_cpu_xor_4(pcp, val) percpu_to_op("xor", (pcp), val)
+#ifndef CONFIG_M386
+#define __this_cpu_add_return_1(pcp, val) percpu_add_return_op((pcp), val)
+#define __this_cpu_add_return_2(pcp, val) percpu_add_return_op((pcp), val)
+#define __this_cpu_add_return_4(pcp, val) percpu_add_return_op((pcp), val)
+#define this_cpu_add_return_1(pcp, val) percpu_add_return_op((pcp), val)
+#define this_cpu_add_return_2(pcp, val) percpu_add_return_op((pcp), val)
+#define this_cpu_add_return_4(pcp, val) percpu_add_return_op((pcp), val)
+#endif
/*
* Per cpu atomic 64 bit operations are only available under 64 bit.
* 32 bit must fall back to generic operations.
@@ -324,6 +371,9 @@ do { \
#define irqsafe_cpu_or_8(pcp, val) percpu_to_op("or", (pcp), val)
#define irqsafe_cpu_xor_8(pcp, val) percpu_to_op("xor", (pcp), val)
+#define __this_cpu_add_return_8(pcp, val) percpu_add_return_op((pcp), val)
+#define this_cpu_add_return_8(pcp, val) percpu_add_return_op((pcp), val)
+
#endif
/* This is not atomic against other CPUs -- CPU preemption needs to be off */
next prev parent reply other threads:[~2010-11-23 23:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 23:51 [thiscpuops upgrade 00/10] Upgrade of this_cpu_ops Christoph Lameter
2010-11-23 23:51 ` [thiscpuops upgrade 01/10] percpucounter: Optimize __percpu_counter_add a bit through the use of this_cpu() options Christoph Lameter
2010-11-24 7:07 ` Pekka Enberg
2010-11-26 15:43 ` Tejun Heo
2010-11-23 23:51 ` [thiscpuops upgrade 02/10] vmstat: Optimize zone counter modifications through the use of this cpu operations Christoph Lameter
2010-11-26 16:25 ` Tejun Heo
2010-11-23 23:51 ` [thiscpuops upgrade 03/10] percpu: Generic support for this_cpu_add,sub,dec,inc_return Christoph Lameter
2010-11-26 16:31 ` Tejun Heo
2010-11-26 16:37 ` Christoph Lameter
2010-11-26 16:39 ` Tejun Heo
2010-11-23 23:51 ` Christoph Lameter [this message]
2010-11-26 16:33 ` [thiscpuops upgrade 04/10] x86: Support " Tejun Heo
2010-11-23 23:51 ` [thiscpuops upgrade 05/10] x86: Use this_cpu_inc_return for nmi counter Christoph Lameter
2010-11-26 16:35 ` Tejun Heo
2010-11-26 17:02 ` Christoph Lameter
2010-11-26 17:05 ` Tejun Heo
2010-11-23 23:51 ` [thiscpuops upgrade 06/10] vmstat: Use this_cpu_inc_return for vm statistics Christoph Lameter
2010-11-23 23:51 ` [thiscpuops upgrade 07/10] highmem: Use this_cpu_xx_return() operations Christoph Lameter
2010-11-23 23:51 ` [thiscpuops upgrade 08/10] percpu: generic this_cpu_cmpxchg() and this_cpu_cmpxchg_double support Christoph Lameter
2010-11-26 16:51 ` Tejun Heo
2010-11-26 16:56 ` Eric Dumazet
2010-11-26 16:58 ` Tejun Heo
2010-11-26 17:01 ` Eric Dumazet
2010-11-26 17:07 ` Tejun Heo
2010-11-26 17:16 ` Eric Dumazet
2010-11-23 23:51 ` [thiscpuops upgrade 09/10] x86: this_cpu_cmpxchg and this_cpu_cmpxchg_double operations Christoph Lameter
2010-11-24 0:41 ` Eric Dumazet
2010-11-24 3:11 ` Christoph Lameter
2010-11-24 7:05 ` Pekka Enberg
2010-11-24 0:44 ` Mathieu Desnoyers
2010-11-23 23:51 ` [thiscpuops upgrade 10/10] Lockless (and preemptless) fastpaths for slub Christoph Lameter
2010-11-24 0:22 ` Eric Dumazet
2010-11-24 3:13 ` Christoph Lameter
2010-11-24 4:37 ` Christoph Lameter
2010-11-24 1:02 ` Mathieu Desnoyers
2010-11-24 1:05 ` Mathieu Desnoyers
2010-11-24 3:09 ` Christoph Lameter
2010-11-24 7:16 ` Pekka Enberg
2010-11-24 16:17 ` Christoph Lameter
2010-11-24 16:37 ` Pekka Enberg
2010-11-24 16:45 ` Christoph Lameter
2010-11-24 16:47 ` Pekka Enberg
2010-11-24 16:55 ` Christoph Lameter
2010-11-24 19:37 ` Jeremy Fitzhardinge
2010-11-24 19:53 ` Christoph Lameter
2010-11-24 20:01 ` Jeremy Fitzhardinge
2010-11-24 19:56 ` Mathieu Desnoyers
2010-11-24 8:15 ` Peter Zijlstra
2010-11-24 16:14 ` Christoph Lameter
2010-11-24 17:26 ` Peter Zijlstra
2010-11-24 18:08 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123235158.236495885@linux.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox