Re: [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init

Liam Girdwood
2010-11-24T10:49:16Z

On Wed, 2010-11-24 at 15:20 +0800, Axel Lin wrote:
> Return PTR_ERR(omap3pandora_dac_reg) instead of 0 if regulator_get failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/omap/omap3pandora.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
> index bff9864..8047c52 100644
> --- a/sound/soc/omap/omap3pandora.c
> +++ b/sound/soc/omap/omap3pandora.c
> @@ -307,6 +307,7 @@ static int __init omap3pandora_soc_init(void)
> pr_err(PREFIX "Failed to get DAC regulator from %s: %ld\n",
> dev_name(&omap3pandora_snd_device->dev),
> PTR_ERR(omap3pandora_dac_reg));
> + ret = PTR_ERR(omap3pandora_dac_reg);
> goto fail3;
> }
>

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.