From: Borislav Petkov <bp@amd64.org>
To: Dave Jones <davej@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>, Neil Brown <neilb@suse.de>,
x86@kernel.org, cpufreq@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Missing "unregister_cpu_notifier" in powernow-k8.c
Date: Wed, 24 Nov 2010 14:13:03 +0100 [thread overview]
Message-ID: <20101124131303.GA24892@aftab> (raw)
In-Reply-To: <20101124090228.GA17766@liondog.tnic>
On Wed, Nov 24, 2010 at 04:02:28AM -0500, Borislav Petkov wrote:
> On Tue, Nov 23, 2010 at 09:31:24PM -0500, Dave Jones wrote:
> > On Tue, Nov 23, 2010 at 09:19:38PM -0500, Dave Jones wrote:
> > > The following might be a partial fix, but I suspect there is probably other
> > > clean-up that is needed.
> >
> > Indeed, looks like another possible leak in the unlikely event that the
> > percpu msr struct can't be allocated..
> > Instead of adding an unregister on fail, I think we can just move the registration later.
>
> Oops, that would be partly my fault, sorry. How about the following
> instead, with proper exit path labels as it is done in other kernel
> code?
>
> [ It is not yet tested but I'll give it a run later on my X6 to verify ]
Ok, I went and fixed up the error message too when Cool'N'Quiet is disabled in
the BIOS. Tested patches coming up...
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-11-24 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 0:28 Missing "unregister_cpu_notifier" in powernow-k8.c Neil Brown
2010-11-24 2:19 ` Dave Jones
2010-11-24 2:31 ` Dave Jones
2010-11-24 9:02 ` Borislav Petkov
2010-11-24 13:13 ` Borislav Petkov [this message]
2010-11-24 13:19 ` [PATCH 1/2] x86, powernow-k8: Fixup missing _PSS objects message Borislav Petkov
2010-11-24 13:19 ` [PATCH 2/2] x86, powernow-k8: Fix exit path Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124131303.GA24892@aftab \
--to=bp@amd64.org \
--cc=bp@alien8.de \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox