From: Don Zickus <dzickus@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
fweisbec@gmail.com, gorcunov@openvz.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] x86, nmi_watchdog: remove the old nmi_watchdog
Date: Wed, 24 Nov 2010 09:08:59 -0500 [thread overview]
Message-ID: <20101124140859.GC22165@redhat.com> (raw)
In-Reply-To: <4CEC853B.6080508@kernel.org>
On Tue, Nov 23, 2010 at 07:23:39PM -0800, Yinghai Lu wrote:
> > - {
> > - .procname = "nmi_watchdog",
> > - .data = &nmi_watchdog_enabled,
> > - .maxlen = sizeof (int),
> > - .mode = 0644,
> > - .proc_handler = proc_nmi_enabled,
> > - },
>
> wonder if you can keep nmi_watchdog in sysctl? So in run-time it could be disabled after it booted up.
Well, with the new code I have watchdog_enabled which does the same thing.
With the nmi watchdog moving to generic code, the idea was to call it a
hardlockup detector. I guess I was trying to rename things to avoid using
nmi all over the place to reflect the idea that a hardlockup might be able
to be used by something other than an nmi.
I can probably wrap this around watchdog_enabled to preserve it I suppose.
Let me know.
Cheers,
Don
next prev parent reply other threads:[~2010-11-24 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 19:32 [PATCH 0/3 v2] x86: Remove old nmi_watchdog Don Zickus
2010-11-23 19:32 ` [PATCH 1/3] x86, NMI: Remove do_nmi_callback logic Don Zickus
2010-11-23 19:32 ` [PATCH 2/3] x86, nmi_watchdog: remove the old nmi_watchdog Don Zickus
2010-11-24 3:23 ` Yinghai Lu
2010-11-24 14:08 ` Don Zickus [this message]
2010-11-24 18:12 ` Yinghai
2010-11-23 19:32 ` [PATCH 3/3] x86, nmi_watchdog: remove all stub function calls from " Don Zickus
2010-11-23 21:49 ` [PATCH 0/3 v2] x86: Remove " Cyrill Gorcunov
2010-11-24 14:03 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124140859.GC22165@redhat.com \
--to=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox