public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ming Lei <tom.leiming@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ian Munsie <imunsie@au1.ibm.com>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH 2/2] perf:tools: figure out start address of kernel map from /proc/kallsyms
Date: Wed, 24 Nov 2010 13:10:46 -0200	[thread overview]
Message-ID: <20101124151046.GC15875@ghostprotocols.net> (raw)
In-Reply-To: <AANLkTimQddY=1RpYpfELqY3sS6x30Nneo+4vGcPjb8r7@mail.gmail.com>

Em Wed, Nov 24, 2010 at 10:38:29PM +0800, Ming Lei escreveu:
> 2010/11/24 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> > Can you please use kallsyms__parse()? Please take a look at
> > event__synthesize_kernel_mmap as it also uses it.
> 
> Good idea, but kallsyms__parse does not pass a parameter
> which indicates if it is a module or kernel symbol to process handler.
> 
> So could you agree on adding one parameter which indicates if
> the current symbol is module symbol to process handler?
> 
> If so, I can use kallsyms__parse.

It passes, for a line like:

ffffffffa00361ce t serio_raw_connect	[serio_raw]

The process callback will receive:

process_symbol(arg=callback arg,
               symbol_name="serio_raw_connect    [serio_raw]",
               symbol_type='T', start=0xffffffffa00361ce)

That is how we figure out if it is a module when splitting the kallsyms
into modules, as kallsyms__parse is also used in:

	dso__load_kallsyms
          dso__load_all_kallsyms
             kallsyms__parse

- Arnaldo

      reply	other threads:[~2010-11-24 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 11:35 [PATCH 2/2] perf:tools: figure out start address of kernel map from /proc/kallsyms tom.leiming
2010-11-24 14:11 ` Arnaldo Carvalho de Melo
2010-11-24 14:38   ` Ming Lei
2010-11-24 15:10     ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101124151046.GC15875@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=tom.leiming@gmail.com \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox