From: Jan Kara <jack@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org,
linux-next <linux-next@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] quota: Use %pV and __attribute__((format (printf in __quota_error and fix fallout
Date: Wed, 24 Nov 2010 17:30:53 +0100 [thread overview]
Message-ID: <20101124163053.GT6113@quack.suse.cz> (raw)
In-Reply-To: <1290610877.11971.59.camel@Joe-Laptop>
On Wed 24-11-10 07:01:17, Joe Perches wrote:
> On Wed, 2010-11-24 at 13:50 +0100, Jan Kara wrote:
> > On Tue 23-11-10 18:49:54, Joe Perches wrote:
> > > Use %pV in __quota_error so a single printk can not be
> > > interleaved with other logging messages.
> > > Add __attribute__((format (printf, 3, 4))) so format
> > > and arguments can be verified by compiler.
> > > Make sure printk formats and arguments match.
> > >
> > > Block # needed a pointer dereference.
> > I already had a similar patch from you in my tree. So I've replaced it.
>
> Perhaps you can get your tree into linux-next.
>
> I believe you only have to send a request to
> Stephen Rothwell (cc'd).
It's there but I didn't push the for_next branch. I'll do that as soon
as I'm able to finish some testing on it...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2010-11-24 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 2:49 [PATCH] quota: Use %pV and __attribute__((format (printf in __quota_error and fix fallout Joe Perches
2010-11-24 12:50 ` Jan Kara
2010-11-24 15:01 ` Joe Perches
2010-11-24 16:30 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124163053.GT6113@quack.suse.cz \
--to=jack@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox