* [PATCH] eeepc-wmi: fix compiler warning
@ 2010-11-03 18:14 Dmitry Torokhov
2010-11-03 18:43 ` Chris Bagwell
2010-11-24 16:52 ` Matthew Garrett
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2010-11-03 18:14 UTC (permalink / raw)
To: Matthew Garrett; +Cc: platform-driver-x86, linux-kernel
This fixes the following:
CC [M] drivers/platform/x86/eeepc-wmi.o
drivers/platform/x86/eeepc-wmi.c:322: warning: initialization from incompatible pointer type
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/platform/x86/eeepc-wmi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
index 462ceab..0d50fbb 100644
--- a/drivers/platform/x86/eeepc-wmi.c
+++ b/drivers/platform/x86/eeepc-wmi.c
@@ -298,8 +298,8 @@ static void eeepc_wmi_notify(u32 value, void *context)
kfree(obj);
}
-static int store_cpufv(struct device *dev, struct device_attribute *attr,
- const char *buf, size_t count)
+static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
{
int value;
struct acpi_buffer input = { (acpi_size)sizeof(value), &value };
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] eeepc-wmi: fix compiler warning
2010-11-03 18:14 [PATCH] eeepc-wmi: fix compiler warning Dmitry Torokhov
@ 2010-11-03 18:43 ` Chris Bagwell
2010-11-14 16:36 ` Corentin Chary
2010-11-24 16:52 ` Matthew Garrett
1 sibling, 1 reply; 4+ messages in thread
From: Chris Bagwell @ 2010-11-03 18:43 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Matthew Garrett, platform-driver-x86, linux-kernel
On Wed, Nov 3, 2010 at 1:14 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> This fixes the following:
>
> CC [M] drivers/platform/x86/eeepc-wmi.o
> drivers/platform/x86/eeepc-wmi.c:322: warning: initialization from incompatible pointer type
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
>
> drivers/platform/x86/eeepc-wmi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
> index 462ceab..0d50fbb 100644
> --- a/drivers/platform/x86/eeepc-wmi.c
> +++ b/drivers/platform/x86/eeepc-wmi.c
> @@ -298,8 +298,8 @@ static void eeepc_wmi_notify(u32 value, void *context)
> kfree(obj);
> }
>
> -static int store_cpufv(struct device *dev, struct device_attribute *attr,
> - const char *buf, size_t count)
> +static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t count)
> {
> int value;
> struct acpi_buffer input = { (acpi_size)sizeof(value), &value };
> --
Opps. Sorry, I missed that warning. ssize_t is obviously correct return value.
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] eeepc-wmi: fix compiler warning
2010-11-03 18:43 ` Chris Bagwell
@ 2010-11-14 16:36 ` Corentin Chary
0 siblings, 0 replies; 4+ messages in thread
From: Corentin Chary @ 2010-11-14 16:36 UTC (permalink / raw)
To: Matthew Garrett
Cc: Chris Bagwell, Dmitry Torokhov, platform-driver-x86, linux-kernel
On Wed, Nov 3, 2010 at 7:43 PM, Chris Bagwell <chris@cnpbagwell.com> wrote:
> On Wed, Nov 3, 2010 at 1:14 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>> This fixes the following:
>>
>> CC [M] drivers/platform/x86/eeepc-wmi.o
>> drivers/platform/x86/eeepc-wmi.c:322: warning: initialization from incompatible pointer type
>>
>> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
>> ---
>>
>> drivers/platform/x86/eeepc-wmi.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>>
>> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
>> index 462ceab..0d50fbb 100644
>> --- a/drivers/platform/x86/eeepc-wmi.c
>> +++ b/drivers/platform/x86/eeepc-wmi.c
>> @@ -298,8 +298,8 @@ static void eeepc_wmi_notify(u32 value, void *context)
>> kfree(obj);
>> }
>>
>> -static int store_cpufv(struct device *dev, struct device_attribute *attr,
>> - const char *buf, size_t count)
>> +static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
>> + const char *buf, size_t count)
>> {
>> int value;
>> struct acpi_buffer input = { (acpi_size)sizeof(value), &value };
>> --
>
> Opps. Sorry, I missed that warning. ssize_t is obviously correct return value.
>
> Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Just queued the same patch on my repo, I should have read the list first.
Matthew can you queue this one for next batch ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] eeepc-wmi: fix compiler warning
2010-11-03 18:14 [PATCH] eeepc-wmi: fix compiler warning Dmitry Torokhov
2010-11-03 18:43 ` Chris Bagwell
@ 2010-11-24 16:52 ` Matthew Garrett
1 sibling, 0 replies; 4+ messages in thread
From: Matthew Garrett @ 2010-11-24 16:52 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: platform-driver-x86, linux-kernel
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-24 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-03 18:14 [PATCH] eeepc-wmi: fix compiler warning Dmitry Torokhov
2010-11-03 18:43 ` Chris Bagwell
2010-11-14 16:36 ` Corentin Chary
2010-11-24 16:52 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox