From: Dave Jones <davej@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: rcu_read_lock/unlock protect find_task_by_vpid call in migrate_pages
Date: Wed, 24 Nov 2010 20:33:36 -0500 [thread overview]
Message-ID: <20101125013336.GA2854@redhat.com> (raw)
In-Reply-To: <20101125095012.F446.A69D9226@jp.fujitsu.com>
On Thu, Nov 25, 2010 at 09:50:37AM +0900, KOSAKI Motohiro wrote:
> > @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
> > goto out;
> > }
> > mm = get_task_mm(task);
> > + rcu_read_unlock();
> > read_unlock(&tasklist_lock);
> >
> > err = -EINVAL;
>
> Thanks reporting. but mmotm seems already has the same patch.
indeed. It's also better than mine, which missed the unlock on error path.
thanks,
Dave
next prev parent reply other threads:[~2010-11-25 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 0:33 rcu_read_lock/unlock protect find_task_by_vpid call in migrate_pages Dave Jones
2010-11-25 0:50 ` KOSAKI Motohiro
2010-11-25 1:33 ` Dave Jones [this message]
2010-11-25 8:42 ` Peter Zijlstra
2010-11-25 9:59 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125013336.GA2854@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox