From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Julia Lawall <julia@diku.dk>, Tom Zanussi <tzanussi@gmail.com>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt@console-pimps.org>
Subject: Re: [RFC PATCHv3] perf tools: add event grouping capability to "perf stat"
Date: Thu, 25 Nov 2010 14:49:40 -0200 [thread overview]
Message-ID: <20101125164939.GG28916@ghostprotocols.net> (raw)
In-Reply-To: <AANLkTin0jv_ka9Bw0mZCeuxTWZfdLOseYdza_3e9vMi+@mail.gmail.com>
Em Thu, Nov 25, 2010 at 03:18:58PM +0100, Stephane Eranian escreveu:
> On Thu, Nov 25, 2010 at 3:12 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > perf-record already does that:
> >
> > if (nr_counters > 1)
> > attr->sample_type |= PERF_SAMPLE_ID;
> >
> Ok, that's good.
> The other thing I saw, is that perf report assumes that sample_type is the
> same for all events, otherwise it dies.
Right, we need to have object attributes, and then pass them to
perf_session__new, so that it creates the counters, etc, instead of
having top, record, etc doing it in ad hoc ways.
I'll try to attack this soon, after tinishing the sample_type_id_all,
that in the kernel is per attribute, but in the tooling side suffers
from the one sample_type per session, not per attribute problem too.
- Arnaldo
next prev parent reply other threads:[~2010-11-25 16:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 1:54 [RFC PATCHv3] perf tools: add event grouping capability to "perf stat" Corey Ashford
2010-11-25 6:32 ` Peter Zijlstra
2010-11-25 7:46 ` Frederic Weisbecker
2010-11-25 8:00 ` Peter Zijlstra
2010-11-25 8:10 ` Frederic Weisbecker
2010-11-25 9:16 ` Stephane Eranian
2010-11-25 13:19 ` Stephane Eranian
2010-11-25 13:19 ` Stephane Eranian
2010-11-25 13:22 ` Stephane Eranian
2010-11-25 14:02 ` Peter Zijlstra
2010-11-25 14:07 ` Stephane Eranian
2010-11-25 14:12 ` Peter Zijlstra
2010-11-25 14:18 ` Stephane Eranian
2010-11-25 14:22 ` Peter Zijlstra
2010-11-25 15:10 ` Lin Ming
2010-11-25 15:15 ` Peter Zijlstra
2010-11-25 15:19 ` Lin Ming
2010-11-25 16:49 ` Arnaldo Carvalho de Melo [this message]
2010-11-26 19:22 ` Corey Ashford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125164939.GG28916@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox