From: Dan Carpenter <error27@gmail.com>
To: Andy Whitcroft <apw@canonical.com>, joe@perches.com
Cc: linux-kernel@vger.kernel.org
Subject: [patch] checkpatch.pl: discourage pointless changes
Date: Thu, 25 Nov 2010 22:25:45 +0300 [thread overview]
Message-ID: <20101125192545.GV1522@bicker> (raw)
This adds a message when people use the --file option to checkpatch.pl:
NOTE: Checkpatch is a only a tool.
Only send patches which make the code unambiguously more readable.
Don't waste maintainer time.
Most people use checkpatch.pl to check patches which they have written,
but newbies use it with the --file option to find things to change.
>From the newbie perspective, we wrote checkpatch.pl so we should
obviously be happy to fix all the errors it reports. But actually
maitainers get cranky and that makes the newbies sad and everyone has
a bad day.
The message is quite blunt, but probably if people's feelings are hurt
by a print from a script that means they are taking the script too
seriously.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3c7fc0..36f95c1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2937,6 +2937,13 @@ sub process {
}
}
+ if ($file && $clean == 0 && $quiet == 0) {
+ print "NOTE: Checkpatch is a only a tool.\n";
+ print " Only send patches which make the code unambiguously more readable.\n";
+ print " Don't waste maintainer time.\n";
+ print "\n";
+ }
+
if ($clean == 1 && $quiet == 0) {
print "$vname has no obvious style problems and is ready for submission.\n"
}
reply other threads:[~2010-11-25 19:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125192545.GV1522@bicker \
--to=error27@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox