From: Samuel Ortiz <sameo@linux.intel.com>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-geode@lists.infradead.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, cjb@laptop.org, dsd@laptop.org
Subject: Re: [PATCH 1/4] MFD: add cs5535-mfd driver for CS5535/CS5536 support
Date: Fri, 26 Nov 2010 11:57:18 +0100 [thread overview]
Message-ID: <20101126105717.GF5520@sortiz-mobl> (raw)
In-Reply-To: <20101023004102.674cdc45@queued.net>
Hi Andres,
On Sat, Oct 23, 2010 at 12:41:02AM -0700, Andres Salomon wrote:
>
> Add an MFD driver to handle the ISA device on CS5535 and CS5536 southbridges.
> This ISA bridge is actually multiple devices; GPIOs, MFGPTs, etc.
The patch looks good, and I applied it.
I just have one minor nitpick though, that you may want to address with a
further patch:
> +config MFD_CS5535
> + tristate "Support for CS5535 and CS5536 southbridge core functions"
An AMD Geode mention should appear here. It might not be obvious to everyone
where those devices can be found.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-11-26 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 7:41 [PATCH 1/4] MFD: add cs5535-mfd driver for CS5535/CS5536 support Andres Salomon
2010-11-12 8:47 ` Andres Salomon
2010-11-12 10:21 ` Samuel Ortiz
2010-11-26 10:57 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126105717.GF5520@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox