From: Samuel Ortiz <sameo@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/14] drivers/mfd: Use printf extension %pR for struct resource
Date: Fri, 26 Nov 2010 12:01:12 +0100 [thread overview]
Message-ID: <20101126110111.GG5520@sortiz-mobl> (raw)
In-Reply-To: <c6c8909d879beb258d2de7d25e82c30673f29ffe.1289597644.git.joe@perches.com>
Hi Joe,
On Fri, Nov 12, 2010 at 01:37:56PM -0800, Joe Perches wrote:
> Using %pR standardizes the struct resource output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Patch applied, thanks.
Cheers,
Samuel.
> ---
> drivers/mfd/sm501.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index bc9275c..78638cf 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -745,11 +745,8 @@ static int sm501_register_device(struct sm501_devdata *sm,
> int ret;
>
> for (ptr = 0; ptr < pdev->num_resources; ptr++) {
> - printk(KERN_DEBUG "%s[%d] flags %08lx: %08llx..%08llx\n",
> - pdev->name, ptr,
> - pdev->resource[ptr].flags,
> - (unsigned long long)pdev->resource[ptr].start,
> - (unsigned long long)pdev->resource[ptr].end);
> + printk(KERN_DEBUG "%s[%d] %pR\n",
> + pdev->name, ptr, &pdev->resource[ptr]);
> }
>
> ret = platform_device_register(pdev);
> --
> 1.7.3.1.g432b3.dirty
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-11-26 11:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 21:37 [PATCH 00/14] Use printf extension %pR for struct resource Joe Perches
2010-11-12 21:37 ` [PATCH 01/14] arch/frv: " Joe Perches
2010-11-12 21:37 ` [PATCH 02/14] arch/mips: " Joe Perches
2010-11-22 20:28 ` Ralf Baechle
2010-11-12 21:37 ` [PATCH 03/14] arch/powerpc: " Joe Perches
2010-11-13 0:42 ` Stephen Rothwell
2010-11-13 0:49 ` [PATCH 03/14 V2] " Joe Perches
2010-11-12 21:37 ` [PATCH 04/14] drivers/dma/ppc4xx: " Joe Perches
2010-11-12 21:37 ` [PATCH 05/14] drivers/infiniband: " Joe Perches
2011-01-06 23:59 ` Roland Dreier
2010-11-12 21:37 ` [PATCH 06/14] drivers/mfd: " Joe Perches
2010-11-26 11:01 ` Samuel Ortiz [this message]
2010-11-12 21:37 ` [PATCH 07/14] drivers/mtd/maps: " Joe Perches
2010-11-26 15:59 ` Artem Bityutskiy
2010-11-12 21:37 ` [PATCH 08/14] drivers/mtd/nand: " Joe Perches
2010-11-12 21:37 ` [PATCH 09/14] drivers/net/can/sja1000: " Joe Perches
2010-11-17 20:29 ` David Miller
2010-11-12 21:38 ` [PATCH 10/14] drivers/parisc: " Joe Perches
2010-11-12 21:38 ` [PATCH 11/14] drivers/rapidio: " Joe Perches
2010-11-12 21:38 ` [PATCH 12/14] drivers/uwb: " Joe Perches
2010-11-12 21:38 ` [PATCH 13/14] drivers/video: " Joe Perches
2010-11-12 21:38 ` [PATCH 14/14] sound/ppc: " Joe Perches
2010-11-22 6:44 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126110111.GG5520@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox