public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: kernel-janitors@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Magnus Damm <damm@opensource.se>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check
Date: Fri, 26 Nov 2010 20:45:33 +0300	[thread overview]
Message-ID: <20101126174533.GA29507@albatros> (raw)
In-Reply-To: <Pine.LNX.4.64.1011261835500.16655@axis700.grange>

Hi Guennadi,

On Fri, Nov 26, 2010 at 18:38 +0100, Guennadi Liakhovetski wrote:
> On Fri, 26 Nov 2010, Vasiliy Kulikov wrote:
> > clk_get() returns ERR_PTR() on error, not NULL.
> > 
> > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> 
> Yep, there are, probably, a couple more of these, similar to

I found a bit more, but I'd like to get feedback on these or just see it
applied first ;)


Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

  reply	other threads:[~2010-11-26 17:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 17:06 [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check Vasiliy Kulikov
2010-11-26 17:38 ` Guennadi Liakhovetski
2010-11-26 17:45   ` Vasiliy Kulikov [this message]
2010-11-27  2:23     ` Paul Mundt
2010-11-29  4:01       ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101126174533.GA29507@albatros \
    --to=segoon@openwall.com \
    --cc=damm@opensource.se \
    --cc=g.liakhovetski@gmx.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox