Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily

Alan Stern
2010-12-02T15:38:53Z

On Thu, 2 Dec 2010, Rafael J. Wysocki wrote:

> OK, so please let me know what you think of the appended patch (on top of the
> previous one).
>
> Thanks,
> Rafael
> Index: linux-2.6/include/linux/suspend.h
> ===================================================================
> --- linux-2.6.orig/include/linux/suspend.h
> +++ linux-2.6/include/linux/suspend.h
> @@ -292,7 +292,7 @@ extern int unregister_pm_notifier(struct
> /* drivers/base/power/wakeup.c */
> extern bool events_check_enabled;
>
> -extern bool pm_check_wakeup_events(void);
> +extern bool pm_wakeup_pending(void);
> extern bool pm_get_wakeup_count(unsigned int *count);
> extern bool pm_save_wakeup_count(unsigned int count);
> #else /* !CONFIG_PM_SLEEP */
> @@ -309,7 +309,7 @@ static inline int unregister_pm_notifier
>
> #define pm_notifier(fn, pri) do { (void)(fn); } while (0)
>
> -static inline bool pm_check_wakeup_events(void) { return true; }
> +static inline bool pm_wakeup_pending(void) { return true; }

Shouldn't this return false?

Alan Stern