Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily

Alan Stern
2010-11-28T15:35:10Z

On Sun, 28 Nov 2010, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Currently dpm_prepare() returns error code if it finds that a device
> being suspended has a pending runtime resume request. However, it
> should not do that if the checking for wakeup events is not enabled.

It doesn't. The line you changed _does_ check device_may_wakeup().

> On the other hand, if the checking for wakeup events is enabled, it
> can return error when a wakeup event is detected, regardless of its
> source.

Will adding this call to pm_wakeup_event() end up double-counting some
events?

Alan Stern