linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Subject: Re: [PATCH v3] Use PHYSDEVOP_get_free_pirq to implement find_unbound_pirq
Date: Mon, 29 Nov 2010 10:29:08 -0500	[thread overview]
Message-ID: <20101129152908.GA19818@dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011251101100.2373@kaball-desktop>

> @@ -611,9 +615,9 @@ int xen_map_pirq_gsi(unsigned pirq, unsigned gsi, int shareable, char *name)
>  
>  	spin_lock(&irq_mapping_update_lock);
>  
> -	if ((pirq > nr_pirqs) || (gsi > nr_irqs)) {
> +	if ((pirq > nr_irqs) || (gsi > nr_irqs)) {
>  		printk(KERN_WARNING "xen_map_pirq_gsi: %s %s is incorrect!\n",
> -			pirq > nr_pirqs ? "nr_pirqs" :"",
> +			pirq > nr_irqs ? "nr_pirqs" :"",

Seems odd to print "nr_pirqs" when that is out of the code.

>  			gsi > nr_irqs ? "nr_irqs" : "");

  reply	other threads:[~2010-11-29 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 11:05 [PATCH v3] Use PHYSDEVOP_get_free_pirq to implement find_unbound_pirq Stefano Stabellini
2010-11-29 15:29 ` Konrad Rzeszutek Wilk [this message]
2010-11-29 17:38   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129152908.GA19818@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Jeremy.Fitzhardinge@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).