* [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe
@ 2010-11-29 6:54 Axel Lin
2010-11-29 6:55 ` [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe Axel Lin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Axel Lin @ 2010-11-29 6:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Timur Tabi, Liam Girdwood, Mark Brown, alsa-devel
Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/fsl/mpc8610_hpcd.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index 0d7dcf1..7d7847a 100644
--- a/sound/soc/fsl/mpc8610_hpcd.c
+++ b/sound/soc/fsl/mpc8610_hpcd.c
@@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "platform device add failed\n");
goto error;
}
+ dev_set_drvdata(&pdev->dev, sound_device);
of_node_put(codec_np);
--
1.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe
2010-11-29 6:54 [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Axel Lin
@ 2010-11-29 6:55 ` Axel Lin
2010-11-29 11:08 ` [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Liam Girdwood
2010-11-29 14:53 ` Timur Tabi
2 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2010-11-29 6:55 UTC (permalink / raw)
To: linux-kernel; +Cc: Timur Tabi, Liam Girdwood, Mark Brown, alsa-devel
Otherwise, calling dev_get_drvdata in p1022_ds_remove returns NULL.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/fsl/p1022_ds.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c
index 63b9eaa..026b756 100644
--- a/sound/soc/fsl/p1022_ds.c
+++ b/sound/soc/fsl/p1022_ds.c
@@ -498,6 +498,7 @@ static int p1022_ds_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "platform device add failed\n");
goto error;
}
+ dev_set_drvdata(&pdev->dev, sound_device);
of_node_put(codec_np);
--
1.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe
2010-11-29 6:54 [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Axel Lin
2010-11-29 6:55 ` [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe Axel Lin
@ 2010-11-29 11:08 ` Liam Girdwood
2010-11-29 14:53 ` Timur Tabi
2 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-11-29 11:08 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Timur Tabi, Mark Brown, alsa-devel
On Mon, 2010-11-29 at 14:54 +0800, Axel Lin wrote:
> Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/fsl/mpc8610_hpcd.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
> index 0d7dcf1..7d7847a 100644
> --- a/sound/soc/fsl/mpc8610_hpcd.c
> +++ b/sound/soc/fsl/mpc8610_hpcd.c
> @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "platform device add failed\n");
> goto error;
> }
> + dev_set_drvdata(&pdev->dev, sound_device);
>
> of_node_put(codec_np);
>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe
2010-11-29 6:54 [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Axel Lin
2010-11-29 6:55 ` [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe Axel Lin
2010-11-29 11:08 ` [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Liam Girdwood
@ 2010-11-29 14:53 ` Timur Tabi
2010-11-29 16:12 ` Mark Brown
2 siblings, 1 reply; 5+ messages in thread
From: Timur Tabi @ 2010-11-29 14:53 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Mark Brown, alsa-devel
Axel Lin wrote:
> Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Both patches:
Acked-by: Timur Tabi <timur@freescale.com>
Thanks for catching this.
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe
2010-11-29 14:53 ` Timur Tabi
@ 2010-11-29 16:12 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2010-11-29 16:12 UTC (permalink / raw)
To: Timur Tabi; +Cc: Axel Lin, linux-kernel, Liam Girdwood, alsa-devel
On Mon, Nov 29, 2010 at 08:53:48AM -0600, Timur Tabi wrote:
> Axel Lin wrote:
> > Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Both patches:
> Acked-by: Timur Tabi <timur@freescale.com>
Applied now.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-29 16:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-29 6:54 [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Axel Lin
2010-11-29 6:55 ` [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe Axel Lin
2010-11-29 11:08 ` [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Liam Girdwood
2010-11-29 14:53 ` Timur Tabi
2010-11-29 16:12 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox