From: Greg KH <greg@kroah.com>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Jiri Slaby <jslaby@suse.cz>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v2 1/2] TTY: don't allow reopen when ldisc is changing
Date: Mon, 29 Nov 2010 14:32:29 -0800 [thread overview]
Message-ID: <20101129223229.GC14663@kroah.com> (raw)
In-Reply-To: <20101129222342.GL15818@bombadil.infradead.org>
On Mon, Nov 29, 2010 at 05:23:42PM -0500, Kyle McMartin wrote:
> On Mon, Nov 29, 2010 at 01:48:37PM -0800, Greg KH wrote:
> > > [<ffffffff8103b189>] warn_slowpath_common+0x80/0x98
> > > [<ffffffff8103b1b6>] warn_slowpath_null+0x15/0x17
> > > [<ffffffff8128a3ab>] tty_open+0x2a2/0x49a
> > > [<ffffffff810fd53f>] chrdev_open+0x11d/0x146
> >
> > Are these two patches also for the .36 kernel? Kyle, you were seeing
> > the warnings show up there, right?
> >
>
> Yup, I guess they turned up when the BKL went away. (I reverted the BKL
> removal patches on top of 2.6.36, and never saw this WARN_ON trigger at
> least.)
Ok, thanks, that helps.
greg k-h
prev parent reply other threads:[~2010-11-29 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 9:16 [PATCH v2 1/2] TTY: don't allow reopen when ldisc is changing Jiri Slaby
2010-11-29 9:16 ` [PATCH v2 2/2] TTY: open/hangup race fixup Jiri Slaby
2010-11-29 21:48 ` [PATCH v2 1/2] TTY: don't allow reopen when ldisc is changing Greg KH
2010-11-29 22:23 ` Kyle McMartin
2010-11-29 22:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129223229.GC14663@kroah.com \
--to=greg@kroah.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox