From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: ltt-dev@lists.casi.polymtl.ca, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ppc asm typo
Date: Mon, 29 Nov 2010 15:08:20 -0800 [thread overview]
Message-ID: <20101129230820.GH2182@linux.vnet.ibm.com> (raw)
In-Reply-To: <20101129225220.GA512@Krystal>
On Mon, Nov 29, 2010 at 05:52:20PM -0500, Mathieu Desnoyers wrote:
> Hi Paul,
>
> This patch has already been merged by me in the userspace RCU library:
>
> commit e72f49371b233637eaf143265a73c7322d0710fd
> Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Date: Wed Sep 23 03:09:59 2009 -0400
>
> ppc atomic: Fix asm format.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
>
> It's therefore already integrated in the current releases.
Hmmm... I wonder why v0.5.2 got me a compiler error, then...
Thanx, Paul
> Thanks,
>
> Mathieu
>
>
> * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> > Fix ppc asm typo.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > diff --git a/urcu/uatomic_arch_ppc.h b/urcu/uatomic_arch_ppc.h
> > index 426b0f2..bb74934 100644
> > --- a/urcu/uatomic_arch_ppc.h
> > +++ b/urcu/uatomic_arch_ppc.h
> > @@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
> > "bne- 1b\n" /* retry if lost reservation */
> > "isync\n"
> > "2:\n"
> > - : "=&r"(old_val),
> > + : "=&r"(old_val)
> > : "r"(addr), "r"((unsigned long)_new),
> > "r"((unsigned long)old)
> > : "memory", "cc");
>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
next prev parent reply other threads:[~2010-11-29 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 22:30 [PATCH] Fix ppc asm typo Paul E. McKenney
2010-11-29 22:52 ` Mathieu Desnoyers
2010-11-29 23:08 ` Paul E. McKenney [this message]
2010-11-29 23:11 ` Mathieu Desnoyers
2010-11-29 23:30 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129230820.GH2182@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@lists.casi.polymtl.ca \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox