Re: [PATCH] Fix ppc asm typo

Mathieu Desnoyers
2010-11-29T23:12:00Z

* Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> On Mon, Nov 29, 2010 at 05:52:20PM -0500, Mathieu Desnoyers wrote:
> > Hi Paul,
> >
> > This patch has already been merged by me in the userspace RCU library:
> >
> > commit e72f49371b233637eaf143265a73c7322d0710fd
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date: Wed Sep 23 03:09:59 2009 -0400
> >
> > ppc atomic: Fix asm format.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> >
> > It's therefore already integrated in the current releases.
>
> Hmmm... I wonder why v0.5.2 got me a compiler error, then...

Maybe you did a make install that got the headers installed system-wide, and the
search order is wrong ? (just a thought)

Did you build 0.5.2 from the tarballs or from the git repo ?

Thanks,

Mathieu

>
> Thanx, Paul
>
> > Thanks,
> >
> > Mathieu
> >
> >
> > * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> > > Fix ppc asm typo.
> > >
> > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > >
> > > diff --git a/urcu/uatomic_arch_ppc.h b/urcu/uatomic_arch_ppc.h
> > > index 426b0f2..bb74934 100644
> > > --- a/urcu/uatomic_arch_ppc.h
> > > +++ b/urcu/uatomic_arch_ppc.h
> > > @@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
> > > "bne- 1b\n" /* retry if lost reservation */
> > > "isync\n"
> > > "2:\n"
> > > - : "=&r"(old_val),
> > > + : "=&r"(old_val)
> > > : "r"(addr), "r"((unsigned long)_new),
> > > "r"((unsigned long)old)
> > > : "memory", "cc");
> >
> > --
> > Mathieu Desnoyers
> > Operating System Efficiency R&D Consultant
> > EfficiOS Inc.
> > http://www.efficios.com

--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.