Re: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad

Takashi Iwai
2010-12-01T06:04:22Z

At Wed, 1 Dec 2010 12:11:04 +0800,
Li, Yan I wrote:
>
> On Tue, Nov 30, 2010 at 11:48:12PM +0800, Tobyn Bertram wrote:
> > I do not have a S10-3t. I have a HP DV7t with a standard 1 button Clickpad.
> > I am sorry for any confusion.
>
> Thank you. This clarify the S10-3t touchpad mystery. So I think my v2
> patch is valid.
>
> > I think that 2 different Clickpads will need to be defined: 1 button
> > Clickpads and 2 button Clickpads. Maybe like this?
> >
> > #define SYN_CAP_CLICKPAD1BTN(ex0c) ((ex0c) & 0x100000)
> > #define SYN_CAP_CLICKPAD2BTN(ex0c) ((ex0c) & 0x000100)
>
> Maybe, although we don't have any code that needs
> SYN_CAP_CLICKPAD2BTN() so far, only 1-button clickpad needs special
> handling, but it's good to have a more precise name.

Agreed. Also, it's interesting to see how 2-button clickpad devices
behave in multi-touch mode...

thanks,

Takashi