RE: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad

Tobyn Bertram
2010-11-30T15:55:00Z

I do not have a S10-3t. I have a HP DV7t with a standard 1 button Clickpad.
I am sorry for any confusion.

I think that 2 different Clickpads will need to be defined: 1 button
Clickpads and 2 button Clickpads. Maybe like this?

#define SYN_CAP_CLICKPAD1BTN(ex0c) ((ex0c) & 0x100000)
#define SYN_CAP_CLICKPAD2BTN(ex0c) ((ex0c) & 0x000100)

Tobyn

-----Original Message-----
From: Li, Yan I [mailto:yan.i.li@intel.com]
Sent: Tuesday, November 30, 2010 12:08 AM
To: Dmitry Torokhov; tobynbertram@hotmail.com
Cc: linux-input@vger.kernel.org; Takashi Iwai; Ding, Jian-feng;
linux-kernel@vger.kernel.org; meego-kernel@lists.meego.com
Subject: Re: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button
ClickPad

On Tue, Nov 30, 2010 at 03:50:26PM +0800, Dmitry Torokhov wrote:
> On Tue, Nov 30, 2010 at 03:44:06PM +0800, Yan Li wrote:
> > This is for kernel bug #18122 and MeeGo bug #4807, version 2.
> >
> > Lenovo S10-3t's ClickPad is a 2-button ClickPad that reports BTN_LEFT
> > and BTN_RIGHT as normal touchpad, unlike the 1-button ClickPad used in
> > HP mini 210 that reports solely BTN_MIDDLE.
> >
> > Of c0-cap response, the 1-button ClickPad has the 20-bit set while
> > 2-button ClickPad has the 8-bit set.
> >
> > This patch makes the kernel only handle 1-button ClickPad specially,
> > and treat 2-button ClickPad as same as other normal touchpads.
> >
>
> As Takashi mentioned, HP Clickpads have the same 0x0c signature than
> Lenovos non-clickpads so this is not that simple. We need to wait and
> see if Christopher will shed some light here...

So the only exception is the one reported by tob. These are the bits
I've collected:

Yan's S10-3t: model: 1, fw: 7.4, id: 0x1e0b1, caps:
0xd04771/0xa40000/0x4a0500 (2 button clickpad)
tob's S10-3t: model: 1, fw: 7.4, id: 0x1e0b1, caps:
0xd04771/0xe40000/0x5a0400 (?)
hp Envy 14/mini210:
model: 1, fw: 7.4, id: 0x1e0b1, caps:
0xd04771/0xe40000/0x5a0400 (1 button clickpad)

I asked tob to double-check his model and whether his touchpad emits
BTN_MIDDLE or not but get no reply yet. I've checked 4 S10-3t
purchased at different dates and all of them show same exc0 cap, but I
have to say other models selling in other parts of the world may be
still different.