2.6.37-rc3 problems

2.6.37-rc3 problems

[werner]

2.6.37-rc3 problems

easycap_main.c lines 4251,4 : implicit declaration 
lock-kernel   ,  unlock_kernel

(compilation error)

wl
---
Professional hosting for everyone - http://www.host.ru

Re: 2.6.37-rc3 problems

[Greg KH]

On Sun, Nov 21, 2010 at 11:20:40PM -0400, werner wrote:
> 2.6.37-rc3 problems
>
> easycap_main.c lines 4251,4 : implicit declaration lock-kernel   ,  
> unlock_kernel
>
> (compilation error)

Either disable this driver from your .config, or enable the BKL in your
.config.  I have a pending patch to get to Linus to fix this Kconfig
issue for this driver.

Are you really using this driver?

thanks,

greg k-h

Re: 2.6.37-rc3 problems

[Randy Dunlap]

On Sun, 21 Nov 2010 20:35:20 -0800 Greg KH wrote:

> On Sun, Nov 21, 2010 at 11:20:40PM -0400, werner wrote:
> > 2.6.37-rc3 problems
> >
> > easycap_main.c lines 4251,4 : implicit declaration lock-kernel   ,  
> > unlock_kernel
> >
> > (compilation error)
> 
> Either disable this driver from your .config, or enable the BKL in your
> .config.  I have a pending patch to get to Linus to fix this Kconfig
> issue for this driver.

The build error happens even when CONFIG_BKL=y.  In fact, that's the only
way to enable EASYCAP, since EASYCAP depends on BKL.

> Are you really using this driver?

Werner builds a distro.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: 2.6.37-rc3 problems

[Randy Dunlap]

On Sun, 21 Nov 2010 20:56:26 -0800 Randy Dunlap wrote:

> On Sun, 21 Nov 2010 20:35:20 -0800 Greg KH wrote:
> 
> > On Sun, Nov 21, 2010 at 11:20:40PM -0400, werner wrote:
> > > 2.6.37-rc3 problems
> > >
> > > easycap_main.c lines 4251,4 : implicit declaration lock-kernel   ,  
> > > unlock_kernel
> > >
> > > (compilation error)
> > 
> > Either disable this driver from your .config, or enable the BKL in your
> > .config.  I have a pending patch to get to Linus to fix this Kconfig
> > issue for this driver.
> 
> The build error happens even when CONFIG_BKL=y.  In fact, that's the only
> way to enable EASYCAP, since EASYCAP depends on BKL.

OTOH, adding <linux/smp_lock.h> to easycap.h fixes the build.


> > Are you really using this driver?
> 
> Werner builds a distro.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: 2.6.37-rc3 problems

[Greg KH]

On Sun, Nov 21, 2010 at 09:13:11PM -0800, Randy Dunlap wrote:
> On Sun, 21 Nov 2010 20:56:26 -0800 Randy Dunlap wrote:
> 
> > On Sun, 21 Nov 2010 20:35:20 -0800 Greg KH wrote:
> > 
> > > On Sun, Nov 21, 2010 at 11:20:40PM -0400, werner wrote:
> > > > 2.6.37-rc3 problems
> > > >
> > > > easycap_main.c lines 4251,4 : implicit declaration lock-kernel   ,  
> > > > unlock_kernel
> > > >
> > > > (compilation error)
> > > 
> > > Either disable this driver from your .config, or enable the BKL in your
> > > .config.  I have a pending patch to get to Linus to fix this Kconfig
> > > issue for this driver.
> > 
> > The build error happens even when CONFIG_BKL=y.  In fact, that's the only
> > way to enable EASYCAP, since EASYCAP depends on BKL.
> 
> OTOH, adding <linux/smp_lock.h> to easycap.h fixes the build.

Ah, nice.  Someone want to send me a patch?  :)

thanks,

greg k-h

[PATCH] staging: easycap needs smp_lock.h, fixes build error

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Add header file to fix build error:

drivers/staging/easycap/easycap_main.c:4251: error: implicit declaration of function 'lock_kernel'
drivers/staging/easycap/easycap_main.c:4254: error: implicit declaration of function 'unlock_kernel'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/staging/easycap/easycap.h |    1 +
 1 file changed, 1 insertion(+)

--- lnx-2637-rc3.orig/drivers/staging/easycap/easycap.h
+++ lnx-2637-rc3/drivers/staging/easycap/easycap.h
@@ -75,6 +75,7 @@
 #include <linux/errno.h>
 #include <linux/init.h>
 #include <linux/slab.h>
+#include <linux/smp_lock.h>
 #include <linux/module.h>
 #include <linux/kref.h>
 #include <linux/usb.h>

Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error

[werner]

HELLO

I dont believe this ... my 2.6.37-rc4 compilation gone bad 
again, because of the same error, and I have to recompile 
/ re-package it, what needs some hours again ..  :(  :(

  The correction below worked on 2.6.37-rc3 (i.e. insert 
#include <linux/smp_lock.h>  into easycap_main.h)


WHY THIS WASN'T PATCHED SINCE LONG TIME ?   Is the 
situation of the kernel developers similar bad like of the 
open office developers, so that they should be exchanged 
???


w.landgraf

===========================================================
On Mon, 22 Nov 2010 12:12:37 -0800
  Randy Dunlap <randy.dunlap@oracle.com> wrote:
>From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Add header file to fix build error:
> 
> drivers/staging/easycap/easycap_main.c:4251: error: 
>implicit declaration of function 'lock_kernel'
> drivers/staging/easycap/easycap_main.c:4254: error: 
>implicit declaration of function 'unlock_kernel'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/staging/easycap/easycap.h |    1 +
> 1 file changed, 1 insertion(+)
> 
> --- lnx-2637-rc3.orig/drivers/staging/easycap/easycap.h
> +++ lnx-2637-rc3/drivers/staging/easycap/easycap.h
> @@ -75,6 +75,7 @@
> #include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> +#include <linux/smp_lock.h>
> #include <linux/module.h>
> #include <linux/kref.h>
> #include <linux/usb.h>
> 
> 

"werner" <w.landgraf@ru.ru>
---
Professional hosting for everyone - http://www.host.ru

Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error

[Greg KH]

On Tue, Nov 30, 2010 at 10:44:21AM -0400, werner wrote:
> HELLO
> 
> I dont believe this ... my 2.6.37-rc4 compilation gone bad again,
> because of the same error, and I have to recompile / re-package it,
> what needs some hours again ..  :(  :(
> 
>  The correction below worked on 2.6.37-rc3 (i.e. insert #include
> <linux/smp_lock.h>  into easycap_main.h)
> 
> 
> WHY THIS WASN'T PATCHED SINCE LONG TIME ?   Is the situation of the
> kernel developers similar bad like of the open office developers, so
> that they should be exchanged ???

This is fixed in Linux-next and will be going to Linus in a few days.

thanks,

greg k-h

Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error

[werner]

OK  For your information, the patch by r.dunlap works on 
2.6.37-rc4 too, the second compilation (including the 
patch) was successful.
wl

===========================
On Tue, 30 Nov 2010 06:57:40 -0800
  Greg KH <greg@kroah.com> wrote:
> On Tue, Nov 30, 2010 at 10:44:21AM -0400, werner wrote:
>> HELLO
>> 
>> I dont believe this ... my 2.6.37-rc4 compilation gone 
>>bad again,
>> because of the same error, and I have to recompile / 
>>re-package it,
>> what needs some hours again ..  :(  :(
>> 
>>  The correction below worked on 2.6.37-rc3 (i.e. insert 
>>#include
>> <linux/smp_lock.h>  into easycap_main.h)
>> 
>> 
>> WHY THIS WASN'T PATCHED SINCE LONG TIME ?   Is the 
>>situation of the
>> kernel developers similar bad like of the open office 
>>developers, so
>> that they should be exchanged ???
> 
> This is fixed in Linux-next and will be going to Linus 
>in a few days.
> 
> thanks,
> 
> greg k-h
> 
> 

"werner" <w.landgraf@ru.ru>
---
Professional hosting for everyone - http://www.host.ru