From: Greg KH <greg@kroah.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: erazor_de@users.sourceforge.net,
Randy Dunlap <rdunlap@xenotime.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Kosina <jkosina@suse.cz>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers
Date: Tue, 30 Nov 2010 09:40:52 -0800 [thread overview]
Message-ID: <20101130174052.GA19977@kroah.com> (raw)
In-Reply-To: <1290804616.3051.52.camel@localhost>
On Fri, Nov 26, 2010 at 08:50:16PM +0000, Ben Hutchings wrote:
> On Fri, 2010-11-26 at 20:57 +0100, Stefan Achatz wrote:
> > Using pack pragma to prevent padding bytes in binary data structures
> > used for hardware communication. Explanation of these pragmas was requested.
> [...]
>
> It would be clearer to use the '__packed' macro after each structure
> definition instead of using this awful Microsoft extension.
I agree, that's the "normal" Linux way of doing things.
Other than that, this patch set looks good to me. Jiri, if the packed
change is made, do you want me to take these through my tree, or do you
want to take them through yours? Whatever is easier for you is fine
with me.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-30 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 19:57 [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers Stefan Achatz
2010-11-26 20:50 ` Ben Hutchings
2010-11-27 7:35 ` [PATCH] HID: roccat: replaced #pragma pack() with __packed macro Stefan Achatz
2010-11-30 17:40 ` Greg KH [this message]
2010-12-02 15:04 ` [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers Jiri Kosina
2010-12-02 15:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130174052.GA19977@kroah.com \
--to=greg@kroah.com \
--cc=bhutchings@solarflare.com \
--cc=erazor_de@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox