From: Eric Cooper <ecc@cmu.edu>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] add netdev led trigger
Date: Tue, 30 Nov 2010 18:22:04 -0500 [thread overview]
Message-ID: <20101130232204.GF21496@localhost> (raw)
In-Reply-To: <20101130192053.GB5295@ucw.cz>
> Please be consistent with rest of kernel...
There seem to be several ways this is done in existing sysfs drivers,
and most aren't documented yet in Documentation/ABI.
1. "0" and "1"
2. "enable" and "disable"
3. "enabled" and "disabled"
4. "enable" and "disable" when writing, but "enabled" and "disabled"
when read back
Some require trailing "\n", others make it optional.
Which is the One True Way?
--
Eric Cooper e c c @ c m u . e d u
next prev parent reply other threads:[~2010-11-30 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 20:58 [PATCH] add netdev led trigger Eric Cooper
2010-11-15 23:41 ` Lars-Peter Clausen
2010-11-17 11:05 ` Pavel Machek
2010-11-17 16:09 ` Greg KH
2010-11-17 19:58 ` Pavel Machek
2010-11-17 20:01 ` Greg KH
2010-11-17 20:06 ` Eric Cooper
2010-11-30 19:20 ` Pavel Machek
2010-11-30 23:22 ` Eric Cooper [this message]
2010-12-01 19:56 ` Pavel Machek
2010-11-21 20:53 ` Eric Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130232204.GF21496@localhost \
--to=ecc@cmu.edu \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox