Re: [PATCH 1/3] Move zone_reclaim() outside of CONFIG_NUMA

Balbir Singh
2010-12-01T05:21:52Z

* Balbir Singh <balbir@linux.vnet.ibm.com> [2010-12-01 10:04:08]:

> * Andrew Morton <akpm@linux-foundation.org> [2010-11-30 14:23:38]:
>
> > On Tue, 30 Nov 2010 15:45:12 +0530
> > Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> >
> > > This patch moves zone_reclaim and associated helpers
> > > outside CONFIG_NUMA. This infrastructure is reused
> > > in the patches for page cache control that follow.
> > >
> >
> > Thereby adding a nice dollop of bloat to everyone's kernel. I don't
> > think that is justifiable given that the audience for this feature is
> > about eight people :(
> >
> > How's about CONFIG_UNMAPPED_PAGECACHE_CONTROL?
> >
>
> OK, I'll add the config, but this code is enabled under CONFIG_NUMA
> today, so the bloat I agree is more for non NUMA users. I'll make
> CONFIG_UNMAPPED_PAGECACHE_CONTROL default if CONFIG_NUMA is set.
>
> > Also this patch instantiates sysctl_min_unmapped_ratio and
> > sysctl_min_slab_ratio on non-NUMA builds but fails to make those
> > tunables actually tunable in procfs. Changes to sysctl.c are
> > needed.
> >
>
> Oh! yeah.. I missed it while refactoring, my fault.
>
> > > Reviewed-by: Christoph Lameter <cl@linux.com>
> >

My local MTA failed to deliver the message, trying again.

--
Three Cheers,
Balbir