From: Jarkko Nikula <jhnikula@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Vladimir Barinov <vbarinov@embeddedalley.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions
Date: Wed, 1 Dec 2010 09:43:16 +0200 [thread overview]
Message-ID: <20101201094316.6751d3a1.jhnikula@gmail.com> (raw)
In-Reply-To: <1291185504.5563.1.camel@mola>
On Wed, 01 Dec 2010 14:38:24 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/tlv320aic3x.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index fc5abdf..8cd4cf5 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1545,21 +1545,6 @@ static struct i2c_driver aic3x_i2c_driver = {
> .remove = aic3x_i2c_remove,
> .id_table = aic3x_i2c_id,
> };
> -
> -static inline void aic3x_i2c_init(void)
> -{
> - int ret;
> -
> - ret = i2c_add_driver(&aic3x_i2c_driver);
> - if (ret)
> - printk(KERN_ERR "%s: error regsitering i2c driver, %d\n",
> - __func__, ret);
> -}
> -
> -static inline void aic3x_i2c_exit(void)
> -{
> - i2c_del_driver(&aic3x_i2c_driver);
> -}
> #endif
>
True, these are unused nowadays.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2010-12-01 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 6:38 [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions Axel Lin
2010-12-01 7:43 ` Jarkko Nikula [this message]
2010-12-01 11:28 ` Mark Brown
2010-12-02 11:52 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201094316.6751d3a1.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=vbarinov@embeddedalley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox