From: Randy Dunlap <rdunlap@xenotime.net>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Tiago Vignatti <tiago.vignatti@nokia.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: vgaarbiter: fix typos
Date: Wed, 1 Dec 2010 16:41:41 -0800 [thread overview]
Message-ID: <20101201164141.abc97309.rdunlap@xenotime.net> (raw)
In-Reply-To: <20101201023457.739373c7@absol.kitzblitz>
On Wed, 1 Dec 2010 02:34:57 +0100 Nicolas Kaiser wrote:
> Fixed typos.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> Documentation/vgaarbiter.txt | 15 +++++++--------
> 1 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/vgaarbiter.txt b/Documentation/vgaarbiter.txt
> index 43a9b06..8145f8f 100644
> --- a/Documentation/vgaarbiter.txt
> +++ b/Documentation/vgaarbiter.txt
> @@ -14,11 +14,10 @@ the legacy VGA arbitration task (besides other bus management tasks) when more
> than one legacy device co-exists on the same machine. But the problem happens
> when these devices are trying to be accessed by different userspace clients
> (e.g. two server in parallel). Their address assignments conflict. Moreover,
> -ideally, being an userspace application, it is not the role of the the X
> -server to control bus resources. Therefore an arbitration scheme outside of
> -the X server is needed to control the sharing of these resources. This
> -document introduces the operation of the VGA arbiter implemented for Linux
> -kernel.
> +ideally, being a userspace application, it is not the role of the X server to
> +control bus resources. Therefore an arbitration scheme outside of the X server
> +is needed to control the sharing of these resources. This document introduces
> +the operation of the VGA arbiter implemented for the Linux kernel.
>
> ----------------------------------------------------------------------------
>
> @@ -39,7 +38,7 @@ I.1 vgaarb
> The vgaarb is a module of the Linux Kernel. When it is initially loaded, it
> scans all PCI devices and adds the VGA ones inside the arbitration. The
> arbiter then enables/disables the decoding on different devices of the VGA
> -legacy instructions. Device which do not want/need to use the arbiter may
> +legacy instructions. Devices which do not want/need to use the arbiter may
> explicitly tell it by calling vga_set_legacy_decoding().
>
> The kernel exports a char device interface (/dev/vga_arbiter) to the clients,
> @@ -95,7 +94,7 @@ In the case of devices hot-{un,}plugged, there is a hook - pci_notify() - to
> notify them being added/removed in the system and automatically added/removed
> in the arbiter.
>
> -There's also a in-kernel API of the arbiter in the case of DRM, vgacon and
> +There's also an in-kernel API of the arbiter in the case of DRM, vgacon and
> others which may use the arbiter.
>
How about:
There is also an in-kernel API of the arbiter in case DRM, vgacon, or other
drivers want to use it.
>
> @@ -117,7 +116,7 @@ Besides it, in pci_system were added:
> struct pci_device *vga_default_dev;
>
>
> -The vga_count is usually need to keep informed how many cards are being
> +The vga_count is usually needed to keep informed how many cards are being
> arbitrated, so for instance if there's only one then it can totally escape the
> scheme.
Awkward. How about:
The vga_count is used to track how many cards are being arbitrated, so for
instance, if there is only one card, then it can completely escape arbitration.
>
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-12-02 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 1:34 [PATCH] Documentation: vgaarbiter: fix typos Nicolas Kaiser
2010-12-02 0:41 ` Randy Dunlap [this message]
2010-12-06 17:25 ` Jesse Barnes
2010-12-06 17:33 ` Randy Dunlap
2011-05-14 10:51 ` [PATCH] Documentation: vgaarbiter: fix typos v2 Nicolas Kaiser
2011-05-14 16:14 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201164141.abc97309.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=tiago.vignatti@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox